Closed Bug 1666355 Opened 8 months ago Closed 8 months ago

Enable keyboard video control shortcuts in the player window by default

Categories

(Toolkit :: Video/Audio Controls, task)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1666355 - Enable Picture-in-Picture player window controls by default to ride the trains. r?jaws!
47 bytes, text/x-phabricator-request
Details | Review

These shortcuts originally landed in bug 1602841, but were held to Nightly because some sites broke when doing certain operations (like seeking).

Now that bug 1662576 has landed (giving us the ability to disable individual keyboard controls on certain sites), astevenson and I think we can let these keyboard controls ride the trains.

Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55a322e75850
Enable Picture-in-Picture player window controls by default to ride the trains. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/55a322e75850

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: qe-verify+

Reproduced the issue on affected Firefox 82.0 (64-bit) on Windows 10 x64.
Verified-fixed on latest Firefox Nightly 84.0a1 (2020-10-22) (64-bit) and Beta 83.0b3 (64-bit) on Windows 10 x64, macOS 10.15 and Ubuntu 16.04.
The "media.videocontrols.picture-in-picture.keyboard-controls.enabled" pref is enabled by default on the mentioned Firefox versions and OS systems.

Status: RESOLVED → VERIFIED
status-firefox83: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.