1666355 - Enable keyboard video control shortcuts in the player window by default

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, task)

Description

[Mike Conley (:mconley) (:⚙️)]

These shortcuts originally landed in bug 1602841, but were held to Nightly because some sites broke when doing certain operations (like seeking).

Now that bug 1662576 has landed (giving us the ability to disable individual keyboard controls on certain sites), astevenson and I think we can let these keyboard controls ride the trains.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1666355 - Enable Picture-in-Picture player window controls by default to ride the trains. r?jaws!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55a322e75850
Enable Picture-in-Picture player window controls by default to ride the trains. r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/55a322e75850

Comment 4

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Firefox 82.0 (64-bit) on Windows 10 x64.
Verified-fixed on latest Firefox Nightly 84.0a1 (2020-10-22) (64-bit) and Beta 83.0b3 (64-bit) on Windows 10 x64, macOS 10.15 and Ubuntu 16.04.
The "media.videocontrols.picture-in-picture.keyboard-controls.enabled" pref is enabled by default on the mentioned Firefox versions and OS systems.