1666588 - Flip default pref for on save recs

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Gavin Suntop [:gvn] (they/them)]

Pref the save on recs experience on by default.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1666588 - Flip default pref for on save recs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24fbb9837b45
Flip default pref for on save recs r=thecount

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/24fbb9837b45

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Similar Stories" recommendations are successfully displayed in the "Saved to Pocket" doorhanger.

Verified using the latest Firefox Nightly (83.0a1 Build ID - 20200930092918) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 9177492 [details]
Bug 1666588 - Flip default pref for on save recs

Beta/Release Uplift Approval Request

• User impact if declined: This is going to help Pocket with some of our q4 reach goals.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. log into Pocket

2. Open a pocket story (easiest to get from newtab)
3. Click the save to Pocket button

expected: should see 3 recs in the bottom of the door hanger.

• List of other uplifts needed: Bug 1666887, Bug 1668247, Bug 1667402
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The change itself is just a pref flip, and is already flipped on in nightly.

It's only medium, and not low, because it's essentially enabling a larger feature with 3 other low to medium uplifts.

• String changes made/needed: none

Comment 6

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Assuming most of the blocking three uplifts make it, preffing this on is going to contribute to our reach goal.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9177492 [details]
Bug 1666588 - Flip default pref for on save recs

approved for 82.0b8

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/94b34ee8c357

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Similar Stories" recommendations are successfully displayed in the "Saved to Pocket" doorhanger.

Verified using the latest Firefox Beta (82.0b9 Build ID - 20201008183927) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.