Remove watermarks in MediaCache
Categories
(Core :: Audio/Video: Playback, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: chunmin, Assigned: chunmin)
References
Details
Attachments
(6 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
mIndexWatermark
and mBlockOwnersWatermark
are no longer in use after bug 1356046, they should be removed from the code.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
In bug 1420798, the mReentrantMonitor
is renamed to mMonitor
.
Depends on D92104
Assignee | ||
Comment 4•4 years ago
|
||
mIndexWatermark
is introduced in bug 1366929 for telemetry MEDIACACHE_WATERMARK_KB
but MEDIACACHE_WATERMARK_KB
is removed in bug 1356046
Depends on D92105
Assignee | ||
Comment 5•4 years ago
|
||
mBlockOwnersWatermark
is introduced in bug 1366936 for telemetry MEDIACACHE_BLOCKOWNERS_WATERMARK
but MEDIACACHE_BLOCKOWNERS_WATERMARK
is removed in bug 1356046
Depends on D92106
Assignee | ||
Comment 6•4 years ago
|
||
AsyncBlockWriter
was removed long time ago. Its comment should be
removed as well.
Depends on D92107
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58fe8384f77d P1: Replace `aNotify` by `aNotifyAll` to align with the comment r=jya https://hg.mozilla.org/integration/autoland/rev/8fccde5a95ff P2: Fix the wrong comment r=jya https://hg.mozilla.org/integration/autoland/rev/68ffdf98fe8c P3: Replace `mReentrantMonitor` by `mMonitor` in comment r=jya https://hg.mozilla.org/integration/autoland/rev/f36aeef489ca P4: Remove `mIndexWatermark` r=jya https://hg.mozilla.org/integration/autoland/rev/2c34546c4119 P5: Remove `mBlockOwnersWatermark` r=jya https://hg.mozilla.org/integration/autoland/rev/accbc58d0f0b P6: Remove the comment for AsyncBlockWriter r=jya
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/58fe8384f77d
https://hg.mozilla.org/mozilla-central/rev/8fccde5a95ff
https://hg.mozilla.org/mozilla-central/rev/68ffdf98fe8c
https://hg.mozilla.org/mozilla-central/rev/f36aeef489ca
https://hg.mozilla.org/mozilla-central/rev/2c34546c4119
https://hg.mozilla.org/mozilla-central/rev/accbc58d0f0b
Description
•