1666805 - Remove watermarks in MediaCache

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P1)

Description

[C.M.Chang[:chunmin]]

mIndexWatermark and mBlockOwnersWatermark are no longer in use after bug 1356046, they should be removed from the code.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P1: Replace `aNotify` by `aNotifyAll` to align with the comment

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P2: Fix the wrong comment

mCurrentMode is initialized to MODE_METADATA [1,2]

[2]: Bug 1421134

Depends on D92103

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P3: Replace `mReentrantMonitor` by `mMonitor` in comment

In bug 1420798, the mReentrantMonitor is renamed to mMonitor.

Depends on D92104

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P4: Remove `mIndexWatermark`

mIndexWatermark is introduced in bug 1366929 for telemetry MEDIACACHE_WATERMARK_KB but MEDIACACHE_WATERMARK_KB is removed in bug 1356046

Depends on D92105

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P5: Remove `mBlockOwnersWatermark`

mBlockOwnersWatermark is introduced in bug 1366936 for telemetry MEDIACACHE_BLOCKOWNERS_WATERMARK but MEDIACACHE_BLOCKOWNERS_WATERMARK is removed in bug 1356046

Depends on D92106

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1666805 - P6: Remove the comment for AsyncBlockWriter

AsyncBlockWriter was removed long time ago. Its comment should be
removed as well.

Depends on D92107

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58fe8384f77d
P1: Replace `aNotify` by `aNotifyAll` to align with the comment r=jya
https://hg.mozilla.org/integration/autoland/rev/8fccde5a95ff
P2: Fix the wrong comment r=jya
https://hg.mozilla.org/integration/autoland/rev/68ffdf98fe8c
P3: Replace `mReentrantMonitor` by `mMonitor` in comment r=jya
https://hg.mozilla.org/integration/autoland/rev/f36aeef489ca
P4: Remove `mIndexWatermark` r=jya
https://hg.mozilla.org/integration/autoland/rev/2c34546c4119
P5: Remove `mBlockOwnersWatermark` r=jya
https://hg.mozilla.org/integration/autoland/rev/accbc58d0f0b
P6: Remove the comment for AsyncBlockWriter r=jya

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58fe8384f77d
https://hg.mozilla.org/mozilla-central/rev/8fccde5a95ff
https://hg.mozilla.org/mozilla-central/rev/68ffdf98fe8c
https://hg.mozilla.org/mozilla-central/rev/f36aeef489ca
https://hg.mozilla.org/mozilla-central/rev/2c34546c4119
https://hg.mozilla.org/mozilla-central/rev/accbc58d0f0b