Closed Bug 1666805 Opened 4 years ago Closed 4 years ago

Remove watermarks in MediaCache

Categories

(Core :: Audio/Video: Playback, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(6 files)

mIndexWatermark and mBlockOwnersWatermark are no longer in use after bug 1356046, they should be removed from the code.

mCurrentMode is initialized to MODE_METADATA [1,2]

[2]: Bug 1421134

Depends on D92103

In bug 1420798, the mReentrantMonitor is renamed to mMonitor.

Depends on D92104

mIndexWatermark is introduced in bug 1366929 for telemetry MEDIACACHE_WATERMARK_KB but MEDIACACHE_WATERMARK_KB is removed in bug 1356046

Depends on D92105

mBlockOwnersWatermark is introduced in bug 1366936 for telemetry MEDIACACHE_BLOCKOWNERS_WATERMARK but MEDIACACHE_BLOCKOWNERS_WATERMARK is removed in bug 1356046

Depends on D92106

AsyncBlockWriter was removed long time ago. Its comment should be
removed as well.

Depends on D92107

Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58fe8384f77d
P1: Replace `aNotify` by `aNotifyAll` to align with the comment r=jya
https://hg.mozilla.org/integration/autoland/rev/8fccde5a95ff
P2: Fix the wrong comment r=jya
https://hg.mozilla.org/integration/autoland/rev/68ffdf98fe8c
P3: Replace `mReentrantMonitor` by `mMonitor` in comment r=jya
https://hg.mozilla.org/integration/autoland/rev/f36aeef489ca
P4: Remove `mIndexWatermark` r=jya
https://hg.mozilla.org/integration/autoland/rev/2c34546c4119
P5: Remove `mBlockOwnersWatermark` r=jya
https://hg.mozilla.org/integration/autoland/rev/accbc58d0f0b
P6: Remove the comment for AsyncBlockWriter r=jya
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: