1667061 - Open the profiler with "active tab" view if the "web developer" preset is selected on the profiler recording panel

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

When users are recording with the "web developer" mode, we should open the Firefox Profiler front-end with the "active tab" view. That way web developers can see a simpler view and concentrate on the details that are relevant to themselves.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1667061 - Format the perf.d.ts file. r?gregtatum

My editor formats this file automatically when I need to change something here,
and it's annoying to exclude these when I need to change something in this
file. I guess it doesn't hurt to format it so we won't have to do that again.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1667061 - Add ProfilerViewMode for preset and append `view` querystring while opening the front-end. r?gregtatum

Depends on D91266

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:canova, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I was waiting for 3 front-end PRs(1, 2, 3) before landing this. They are all landed now. I will do a deploy on the front-end and land these patches today.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f374a2996151
Format the perf.d.ts file. r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/af2cb6cee546
Add ProfilerViewMode for preset and append `view` querystring while opening the front-end. r=gregtatum

Comment 6

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ExqasjpIR2ea3H0XNjKIWQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=af2cb6cee5467f572961454ec422e108fce40876

Log: https://treeherder.mozilla.org/logviewer?job_id=323460936&repo=autoland&lineNumber=3701

Backout: https://hg.mozilla.org/integration/autoland/rev/d3c578f62cea2db87afd7acb556c54ffbcedd544

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c23bc13b4d0e
Format the perf.d.ts file. r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/f4de106692bf
Add ProfilerViewMode for preset and append `view` querystring while opening the front-end. r=gregtatum

Comment 8

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Fixed the failures and landed again. Thanks.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c23bc13b4d0e
https://hg.mozilla.org/mozilla-central/rev/f4de106692bf