Consolidate typeaheadfind files with other browser installation/pref files

VERIFIED FIXED in mozilla1.1final

Status

SeaMonkey
Find In Page
P3
normal
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

Trunk
mozilla1.1final
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

16 years ago
There is really no need for a separate typeaheadfind.js prefs file. Those 4
lines should just go into all.js.

In addition, there is no need for a separate typeaheadfind.xpi - it should go
into browser.xpi.
(Assignee)

Updated

16 years ago
Blocks: 30088
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1final
(Assignee)

Comment 1

16 years ago
We don't really need our own .properties file either, that stuff can go into a
more global properties file.
(Assignee)

Comment 2

16 years ago
I won't put my .properties strings somewhere else if it doesn't make sense.

Typeaheadfind probably shouldn't be done is an extension any more, even though
it will be optional for embeddors. However, it makes installation a lot easier
if we get rid of the resources, which we don't really need. It's only a 5 line
.properties file and a 4 line prefs file.

Dveditz, you mentioned that my properties strings won't get localized the way I
have it now.

So, should I or should I not do this? And if I do, where should my .properties
strings go if I do get rid of typeaheadfind.properties. If I don't, how do I
make sure this stuff gets localized?
(Assignee)

Comment 3

16 years ago
Perhaps typeaheadfind should be moved out of extensions - to where, I don't know.
(Assignee)

Comment 4

16 years ago
Perhaps the typeaheadfind.properties should stay separate, but go in embed.jar

Updated

16 years ago
Summary: Consolodate typeaheadfind files with other browser installation/pref files → Consolidate typeaheadfind files with other browser installation/pref files
(Assignee)

Comment 5

16 years ago
Tao, what's a good general purpose .properties file that embeddors get. I'm
thinking of moving my properties strings into there, so that all typeaheadfind
requires for install is the binary component.

Comment 6

16 years ago
dveditz, why do we want to merge the typeaheadfind files into browser.xpi?  are
you just trying to sreamline the set of packages/files in the product?

aaron said that you just didn't want it as an option in the installer.  this can
easily be accomplished via the installer's config.ini file.

just curious

Comment 7

16 years ago
In general, you need to consider where the typeaheadfind belongs in terms of its
feature. For example, if you believe it is a core Gecko feature, then put it in
under "global" or "toolkit" package. If it is an application feature, put in
"navigator" or "communicator". However, if it is an extension/add-on, then you
want to put it in a separate package and xpi so applications can decide whether
to include it in their distribution package.
Is this a standard part of the browser Mozilla ships? Is there really some
customizer that's going to want to turn this off? Sure, we could create a
cookie.xpi, a wallet.xpi, a bookmark.xpi and have a separate package for each
featurette, but that would be insane.

This sounds like a basic browsing feature so make it one. If it's optional fluff
then we shouldn't waste time on it. With all the overhead of separate chrome,
separate installs (12 of them! (moz+ns)*(platforms)*(Mozilla+embed) ), separate
package lists (only 6), the need to localize stuff that's not in the language
pack, etc, etc. Insanity, I say, insanity!

Comment 9

16 years ago
Note that if the sole purpose of putting this feature in a separate package is to 
allow the application to disable it, then, a user preference would do the trick.

Updated

16 years ago
Blocks: 66877
(Assignee)

Comment 10

16 years ago
Created attachment 100803 [details] [diff] [review]
Consolodates files and cleans up packing for  Mozilla XUL client, and makes it possible embeddors to add it

Seeking r=cls for makefile changes, r=ssu for the rest and sr=dveditz


* Puts properties files into en-US.jar as
chrome://navigator/locale/typeaheadfind.properties
* Puts prefs into all.js
* Puts commented out lines into embedding package files basebrowser* so that
embeddors can easily choose to add typeaheadfind (I tested with mfcembed, it
works)
* Becomes part of browser.xpi instead of using it's own xpi
* Eliminates 5 now unnecessary files in the typeaheadfind directory
(Assignee)

Comment 11

16 years ago
Created attachment 100813 [details] [diff] [review]
Patch for Netscape

Need r=ssu, sr=dveditz for this one too.
It just adds typeaheadfind to the trunk Netscape installer.
Comment on attachment 100813 [details] [diff] [review]
Patch for Netscape

Why is typeaheadfind.so always being compiled as a shared lib in a static build
if it's going to be part of the default browser.xpi ?  The Makefile.in changes
look fine.
(Assignee)

Comment 13

16 years ago
Cls, there's no good reason for that -- how do I fix it? Should I file a
separate bug for that?
Hrm.  You'd just remove the FORCE_SHARED_LIB setting from the Makefile.in.  But
it looks like that variable is not being set so the package files for the static
builds are wrong.

Comment 15

16 years ago
Comment on attachment 100813 [details] [diff] [review]
Patch for Netscape

This looks like the patch for mozilla.	Can you attach the ns patch?

Comment 16

16 years ago
Comment on attachment 100803 [details] [diff] [review]
Consolodates files and cleans up packing for  Mozilla XUL client, and makes it possible embeddors to add it

r=ssu
Attachment #100803 - Flags: review+
(Assignee)

Comment 17

16 years ago
Created attachment 100894 [details] [diff] [review]
Correct patch for Netscape
Attachment #100813 - Attachment is obsolete: true
(Assignee)

Comment 18

16 years ago
I've removed the .dll/.so from packages-static-unix and packages-static-win, but
kept the .xpt files listed in there. Do I need to submit a new patch?

Comment 19

16 years ago
Comment on attachment 100894 [details] [diff] [review]
Correct patch for Netscape

r=ssu  *if* ns' config.it does not have the type ahead component descriptions
(because I don't see it being removed in this patch).
Attachment #100894 - Flags: review+
(Assignee)

Comment 20

16 years ago
That's correct ssu -- I hadn't touched the ns stuff for typeaheadfidn before
this bug.
Comment on attachment 100803 [details] [diff] [review]
Consolodates files and cleans up packing for  Mozilla XUL client, and makes it possible embeddors to add it

sr=dveditz
Attachment #100803 - Flags: superreview+
You shouldn't need to add your stuff to the ns package list. The commercial
build process runs the mozilla package lists on the commercial tree first, and
then the netscape package files are just for the things that have to be
overridden. You don't have different "commercial" versions of these files, right?
(Assignee)

Comment 23

16 years ago
Okay, I won't check in the Netscape stuff then.
(Assignee)

Comment 24

16 years ago
checked in

cls, ssu, dveditz - thanks for the help!

Note to Netscape QA:
Typeaheadfind should now be part of both Mozilla and Netscape nightly builds on
all platforms. Embeddors can get it by uncommenting the typeaheadfiles in their
packages file.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
cc'ing ktrina (install QA) so that she's aware of the changes.
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 26

16 years ago
Created attachment 101166 [details] [diff] [review]
Fixes errors in last checkin. Get rid of  typeaheadfind.jst, make sure typeaheadfind is not references in config.it or makeall.pl files, also fixes spelling of typeaheadfind.dll in packages-os2

Seeking quick r=/sr=
Attachment #100894 - Attachment is obsolete: true
(Assignee)

Comment 27

16 years ago
Reopening for some problems ssu and I discovered. Patch already attached.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 28

16 years ago
Comment on attachment 101166 [details] [diff] [review]
Fixes errors in last checkin. Get rid of  typeaheadfind.jst, make sure typeaheadfind is not references in config.it or makeall.pl files, also fixes spelling of typeaheadfind.dll in packages-os2

r=ssu
Attachment #101166 - Flags: review+
Comment on attachment 101166 [details] [diff] [review]
Fixes errors in last checkin. Get rid of  typeaheadfind.jst, make sure typeaheadfind is not references in config.it or makeall.pl files, also fixes spelling of typeaheadfind.dll in packages-os2

>Index: packager/packages-os2
>===================================================================
> bin/components/typeaheadfind.xpt
>-bin/components/typeheadfind.dll
>+bin/components/typeaheadfind.dll
> 
>-[typeaheadfind]
>-bin/components/typahead.dll

When moving this entry you changed the name, but I don't see any os2
build system changes. Did the old entry not work? Is it the new
entry that's broken? I think os2 has an 8.3 requirement for executable
files so I tend to trust typahead.dll a little more, but check.
(Assignee)

Updated

16 years ago
Blocks: 171355
Comment on attachment 101166 [details] [diff] [review]
Fixes errors in last checkin. Get rid of  typeaheadfind.jst, make sure typeaheadfind is not references in config.it or makeall.pl files, also fixes spelling of typeaheadfind.dll in packages-os2

sr=dveditz as you said via IM you're changing the os2 package file to use the
typahead.dll shortname.
Attachment #101166 - Flags: superreview+
(Assignee)

Comment 31

16 years ago
checked in
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2002.10.08.08 (comm trunk, eg, linux rh7.2). type ahead find
prefs are now in all.js; typeaheadfind.js is no longer around in the
default/pref/ dir.
Status: RESOLVED → VERIFIED

Updated

15 years ago
Component: Keyboard: Navigation → Keyboard: Find as you Type
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.