Closed
Bug 166736
Opened 22 years ago
Closed 22 years ago
clicking on view image while page is loading causes the back button to notgo to the last page, but the page before last.
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: maybespamforandy1, Assigned: radha)
References
()
Details
Attachments
(1 file)
6.48 KB,
patch
|
adamlock
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
if you click on view image on an image, while the rest of the page is loading,
clicking back after you are on the screen that you are viewing the image, goes
to the page before the page that you clicked on view image, or the back button
is greyed out if the page that you clicked view image on was the first page that
you opened in that window.
Comment 1•22 years ago
|
||
*** Bug 176204 has been marked as a duplicate of this bug. ***
Comment 2•22 years ago
|
||
Confirmed on http://biology.ecsu.ctstateu.edu/People/adams.htm with Phoenix
11/02 on WinXP.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•22 years ago
|
||
... and confirmed in Mozilla 10/25.
-> History: Session. If this turns out to be a context menu bug, Mozilla and
Phoenix will need separate fixes.
Assignee: asa → radha
Component: Browser-General → History: Session
QA Contact: asa → claudius
Comment 4•22 years ago
|
||
*** Bug 179299 has been marked as a duplicate of this bug. ***
Comment 5•22 years ago
|
||
Still here on Linux and WinXP too...
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4alpha
also on Win98 with 1.3b
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030210
Assignee | ||
Comment 7•22 years ago
|
||
*** Bug 168987 has been marked as a duplicate of this bug. ***
Updated•22 years ago
|
OS: Windows 2000 → All
Assignee | ||
Comment 8•22 years ago
|
||
This patch introduces a new flag mIsExecutingOnLoadHandler and uses it
(instead of busy flags) to track loads that happen in onLoad handlers. This
is required so that loads from onLoad handlers can be clearly distinguished
from the ones that are interrupted, cancelled etc ....
Assignee | ||
Updated•22 years ago
|
Attachment #116113 -
Flags: review?(adamlock)
Comment on attachment 116113 [details] [diff] [review]
patch to docshell
r=adamlock
Attachment #116113 -
Flags: review?(adamlock) → review+
Assignee | ||
Updated•22 years ago
|
Attachment #116113 -
Flags: superreview?(alecf)
Comment 10•22 years ago
|
||
Comment on attachment 116113 [details] [diff] [review]
patch to docshell
sorry for the delay. My only qualm with this is that
"isExecutingOnLoadHandler()" should not be a method, but instead should be
"readonly attribute boolean isExecutingOnLoadHandler;"
and mIsExecutingOnLoadHandler should be a PRPackedBool
sr=alecf with those changes
Attachment #116113 -
Flags: superreview?(alecf) → superreview+
Assignee | ||
Comment 11•22 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 12•22 years ago
|
||
This caused regression bug 201108
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•