166736 - clicking on view image while page is loading causes the back button to notgo to the last page, but the page before last.

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[andy]

if you click on view image on an image, while the rest of the page is loading,
clicking back after you are on the screen that you are viewing the image, goes
to the page before the page that you clicked on view image, or the back button
is greyed out if the page that you clicked view image on was the first page that
you opened in that window.

Comment 1

[Jesse Ruderman]

*** Bug 176204 has been marked as a duplicate of this bug. ***

Comment 2

[Jesse Ruderman]

Confirmed on http://biology.ecsu.ctstateu.edu/People/adams.htm with Phoenix
11/02 on WinXP.

Comment 3

[Jesse Ruderman]

... and confirmed in Mozilla 10/25.

-> History: Session.  If this turns out to be a context menu bug, Mozilla and
Phoenix will need separate fixes.

Comment 4

[Jesse Ruderman]

*** Bug 179299 has been marked as a duplicate of this bug. ***

Comment 5

[Grey Hodge (jX)]

Still here on Linux and WinXP too...

Comment 6

[Craig]

also on Win98 with 1.3b
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030210

Comment 7

[Radha on family leave (not reading bugmail)]

*** Bug 168987 has been marked as a duplicate of this bug. ***

Comment 8

[Radha on family leave (not reading bugmail)]

Attachment: patch to docshell

This patch  introduces a new flag mIsExecutingOnLoadHandler and uses it
(instead of busy flags) to track loads that happen in onLoad handlers.	 This
is required so that loads from onLoad handlers can be clearly distinguished
from the ones that are interrupted, cancelled etc ....

Comment 9

[Adam Lock]

Comment on attachment 116113 [details] [diff] [review]
patch to docshell

r=adamlock

Comment 10

[Alec Flett]

Comment on attachment 116113 [details] [diff] [review]
patch to docshell

sorry for the delay. My only qualm with this is that
"isExecutingOnLoadHandler()" should not be a method, but instead should be
"readonly attribute boolean isExecutingOnLoadHandler;"

and mIsExecutingOnLoadHandler should be a PRPackedBool

sr=alecf with those changes

Comment 11

[Radha on family leave (not reading bugmail)]

Fix checked in. 

Comment 12

[Boris Zbarsky [:bzbarsky]]

This caused regression bug 201108