1667381 - Implement a doorhanger to notify Fission experiment users

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Neha Kochar [:neha]]

Show a doorhanger to inform users that they have Fission enabled for those who get into the Fission Nightly experiment. We should show this only one time when it gets enabled for them for the first time, otherwise it might get annoying for the user. There should also be a link for 'Find more' and a close option.
The exact text for it can be discussed and decided.

Comment 1

[Neha Kochar [:neha]]

Nika is working on another change for the prefs, building on top of kmag's changes in bug 1660057, so NI'ing her so she can coordinate with yoric.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Where do we have a "Find more"?

Comment 3

[Neha Kochar [:neha]]

I think we should point to Fission wiki for the Find more link. Anny is also working on a blog so if that's ready in time, we can point to that.

Comment 4

[Neha Kochar [:neha]]

Tim, can you point to someone to give some handy pointers to yoric for implementing this for Fission Nightly experiment users?

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1667381 - Implement a doorhanger to notify Fission experiment users;r?nhnt11

Comment 6

[Tim Spurway [:tspurway]]

(In reply to Neha Kochar [:neha] from comment #4)

Tim, can you point to someone to give some handy pointers to yoric for implementing this for Fission Nightly experiment users?

:andreio is the tech lead for Messaging System and can help out yoric

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1667381 - Expose a new target attribute isFissionExperimentEnabled;r?andreio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d4a7bc1009
Implement a doorhanger to notify Fission experiment users;r=fluent-reviewers,andreio,neha

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b9d4a7bc1009

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7a131ba97b7
Expose a new target attribute isFissionExperimentEnabled;r=andreio

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c7a131ba97b7

Comment 12

[David Teller [:Yoric] - still alive but not very active]

@andreio, according to bug 1669497 apparently the doorhanger shows even when it shouldn't, so possibly when isFissionExperimentEnabled is false. Do you spot anything wrong, either here or on https://github.com/mozilla/messaging-system-inflight-assets/pull/156/files ?

Comment 13

[David Teller [:Yoric] - still alive but not very active]

Nika, could you double-check that I've understood correctly your instructions to implement isFissionExperimentEnabled ?

Comment 14

[Andrei Oprea [:andreio]]

I'm going to follow up with QA and see if there's anything about targeting that can cause this. Since that is the only attribute in the targeting (and the code to expose it is trivial) I can't see any other reason where things could have gone wrong.

Comment 15

[Nika Layzell [:nika] (ni? for response)]

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #13)

Nika, could you double-check that I've understood correctly your instructions to implement isFissionExperimentEnabled ?

No, that attribute is incorrect. Services.appinfo.fissionExperimentStatus is an enum with integer values, and you're interpreting it as a boolean, which will produce incorrect results. Please change the code to instead check:

return Services.appinfo.fissionExperimentStatus == Ci.nsIXULRuntime.eExperimentStatusTreatment;

Comment 16

[David Teller [:Yoric] - still alive but not very active]

Gasp. I'm too used to strongly-typed languages.
(also, I feel stupid)

Thanks, Nika!

Comment 17

[Maria Heres, inactive, contact Ecosystem QA]

I am marking this as verified fixed based on the testing performed for PI-778 - QA sign-off for Fission experiment recipe. The complete list of bugs found during testing can be found here.

The experiment was tested using Firefox Nightly 83.0a1 (Build IDs 20201004212809 through 20201009041754) on Windows 10, Windows 7 and macOS 10.15.