Closed Bug 1667381 Opened 1 year ago Closed 1 year ago

Implement a doorhanger to notify Fission experiment users

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
83 Branch
Fission Milestone M6b
Tracking Status
firefox83 --- verified

People

(Reporter: neha, Assigned: Yoric)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

Show a doorhanger to inform users that they have Fission enabled for those who get into the Fission Nightly experiment. We should show this only one time when it gets enabled for them for the first time, otherwise it might get annoying for the user. There should also be a link for 'Find more' and a close option.
The exact text for it can be discussed and decided.

Nika is working on another change for the prefs, building on top of kmag's changes in bug 1660057, so NI'ing her so she can coordinate with yoric.

Assignee: nobody → dteller
Severity: -- → S3
Status: NEW → ASSIGNED
Fission Milestone: --- → M6b
Flags: needinfo?(nika)
Priority: -- → P2
Component: General → Messaging System

Where do we have a "Find more"?

Flags: needinfo?(nkochar)

I think we should point to Fission wiki for the Find more link. Anny is also working on a blog so if that's ready in time, we can point to that.

Flags: needinfo?(nkochar)
Depends on: 1667426

Tim, can you point to someone to give some handy pointers to yoric for implementing this for Fission Nightly experiment users?

Flags: needinfo?(nika) → needinfo?(tspurway)

(In reply to Neha Kochar [:neha] from comment #4)

Tim, can you point to someone to give some handy pointers to yoric for implementing this for Fission Nightly experiment users?

:andreio is the tech lead for Messaging System and can help out yoric

Flags: needinfo?(tspurway)
Pushed by dteller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9d4a7bc1009
Implement a doorhanger to notify Fission experiment users;r=fluent-reviewers,andreio,neha
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7a131ba97b7
Expose a new target attribute isFissionExperimentEnabled;r=andreio

@andreio, according to bug 1669497 apparently the doorhanger shows even when it shouldn't, so possibly when isFissionExperimentEnabled is false. Do you spot anything wrong, either here or on https://github.com/mozilla/messaging-system-inflight-assets/pull/156/files ?

Flags: needinfo?(andrei.br92)

Nika, could you double-check that I've understood correctly your instructions to implement isFissionExperimentEnabled ?

Flags: needinfo?(nika)

I'm going to follow up with QA and see if there's anything about targeting that can cause this. Since that is the only attribute in the targeting (and the code to expose it is trivial) I can't see any other reason where things could have gone wrong.

Flags: needinfo?(andrei.br92)

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #13)

Nika, could you double-check that I've understood correctly your instructions to implement isFissionExperimentEnabled ?

No, that attribute is incorrect. Services.appinfo.fissionExperimentStatus is an enum with integer values, and you're interpreting it as a boolean, which will produce incorrect results. Please change the code to instead check:

return Services.appinfo.fissionExperimentStatus == Ci.nsIXULRuntime.eExperimentStatusTreatment;
Flags: needinfo?(nika) → needinfo?(dteller)

Gasp. I'm too used to strongly-typed languages.
(also, I feel stupid)

Thanks, Nika!

Flags: needinfo?(dteller)

I am marking this as verified fixed based on the testing performed for PI-778 - QA sign-off for Fission experiment recipe. The complete list of bugs found during testing can be found here.

The experiment was tested using Firefox Nightly 83.0a1 (Build IDs 20201004212809 through 20201009041754) on Windows 10, Windows 7 and macOS 10.15.

Status: RESOLVED → VERIFIED
Depends on: 1693207
You need to log in before you can comment on or make changes to this bug.