1667426 - Further streamlining of fission pref configuration for experiment

Status: VERIFIED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

The initial version of this was implemented in bug 1660057, but further discussions with data-science and normandy folks reveals that there are a few follow-up changes we should be making.

This bug is to track making these follow-up changes.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1667426 - Part 1: Add fission enablement to TelemetryEnvironment,

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1667426 - fisison.autostart/normandy pref integration improvements,

Comment 3

[Phabricator Automation]

Comment on attachment 9178368 [details]
Bug 1667426 - Part 1: Add fission enablement to TelemetryEnvironment,

Revision D91686 was moved to bug 1668054. Setting attachment 9178368 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdd402fe6537
fisison.autostart/normandy pref integration improvements, r=kmag,mythmon

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1668054, bug 1667426) for Browser-chrome failure in toolkit/modules/tests/browser/browser_Troubleshoot.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317322468&repo=autoland&lineNumber=8855

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0a0ad7d6a16b9cb5d72b0bbb388409054cc3d919

Backout:
https://hg.mozilla.org/integration/autoland/rev/0acb34a4e5f35fe24be33cb1fff95502bf2e386a

Comment 6

[Andrew McCreight [:mccr8]]

I'll work on fixing the test failure and relanding.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d04e9d7061ec
fisison.autostart/normandy pref integration improvements, r=kmag,mythmon

Comment 8

[Andrew McCreight [:mccr8]]

Looks like Nika fixed it.

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1667426 - Part 2: Fix failing browser_Troubleshoot.js test

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49c4bb4afe25
Part 2: Fix failing browser_Troubleshoot.js test r=fix CLOSED TREE

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d04e9d7061ec
https://hg.mozilla.org/mozilla-central/rev/49c4bb4afe25

Comment 12

[Maria Heres, inactive, contact Ecosystem QA]

I am marking this as verified fixed based on the testing performed for PI-778 - QA sign-off for Fission experiment recipe. The complete list of bugs found during testing can be found here.

The experiment was tested using Firefox Nightly 83.0a1 (Build IDs 20201004212809 through 20201009041754) on Windows 10, Windows 7 and macOS 10.15.