Please create "desktop-theme-reviewers" group and a matching Herald rule
Categories
(Conduit :: Phabricator, task)
Tracking
(Not tracked)
People
(Reporter: ntim, Unassigned)
References
Details
+++ This bug was initially created as a clone of Bug #1646121 +++
For changes to code in the Firefox Desktop theme, which are their own submodule, please create a desktop-theme-reviewers (with desktop-theme as alias) group containing:
- Dão Gottwald, https://phabricator.services.mozilla.com/p/dao/
- Tim Nguyen, https://phabricator.services.mozilla.com/p/ntim/
Please also create a Herald rule to add the group as a non-blocking reviewer for files inside any of the following paths:
browser/themestoolkit/themes
Thank you. :)
|
||
Comment 1•4 years ago
|
||
Created
https://phabricator.services.mozilla.com/project/profile/141/
https://phabricator.services.mozilla.com/H274
|
Reporter | |
Comment 2•4 years ago
|
||
Thanks!
|
|
Reporter | |
Comment 3•4 years ago
•
|
||
Hi, in https://phabricator.services.mozilla.com/D91451, I see the reviewer group keeps getting re-added. Is it possible to stop re-adding it if it's been removed once (by one of the group members if that's easier)?
Also, would it be possible to allow members of the group to edit https://phabricator.services.mozilla.com/H274 ? Thanks!
|
|
||
Comment 4•4 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #3)
Hi, in https://phabricator.services.mozilla.com/D91451, I see the reviewer group keeps getting re-added. Is it possible to stop re-adding it if it's been removed once (by one of the group members if that's easier)?
Yeah. I have changed to the rule to "Take these actions the first time this rule matches".
Also, would it be possible to allow members of the group to edit https://phabricator.services.mozilla.com/H274 ? Thanks!
Unfortunately as it is a global rule and not a personal rule, it can only be edited by admins. This is a limitation of Phabricator. We can make any changes you need.
|
|
Reporter | |
Comment 5•4 years ago
•
|
||
(In reply to David Lawrence [:dkl] from comment #4)
(In reply to Tim Nguyen :ntim from comment #3)
Hi, in https://phabricator.services.mozilla.com/D91451, I see the reviewer group keeps getting re-added. Is it possible to stop re-adding it if it's been removed once (by one of the group members if that's easier)?
Yeah. I have changed to the rule to "Take these actions the first time this rule matches".
Seems to work well, thanks!
Also, would it be possible to allow members of the group to edit https://phabricator.services.mozilla.com/H274 ? Thanks!
Unfortunately as it is a global rule and not a personal rule, it can only be edited by admins. This is a limitation of Phabricator. We can make any changes you need.
No worries, thanks for your help!
Description
•