16677 - nsIPluginManager::FindProxyForURL isn't aware of "bypass proxies for local addresses"

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[edburns]

This bug is an upshoot from bug
http://bugzilla.mozilla.org/show_bug.cgi?id=15607

The problem is that FindProxyForURL isn't aware of the "bypass proxies for
local hosts" feature.

However, I don't know how this relates to "auto-configuration".  Robert Yang,
could you please elaborate?

Thanks,

ed

Comment 1

[Robert H. Yang]

Under NS 4.7 proxy preferences one can observe the following :

1. Direct connection to internet.
2. Manual proxy connection.
3. Automatic proxy configuration URL.

Under item 2 (manual proxy configuration) there is a textbox for "Do not use
proxy servers for domains beginning with :"  This is the proxy exclusion list.
Addresses which begin with these names are not to be proxied.

Under item 3 (Automatic proxy configuration) there is a textbox for the URL of
a .pac file which contains javascript code as per the following :

http://home.netscape.com/eng/mozilla/2.0/relnotes/demo/proxy-live.html

This code is then used to determine what the proxy is.  Please let me know if
more info is needed.

Comment 2

[edburns]

Created a new bug for this, and made 16677 depend on it.  17158

Comment 3

[Eli Goldberg]

Shrirang is now QA owner for Plug-ins; QA assigning all of my Plug-ins bugs over
to him.

Comment 4

[scott.feier]

This is fairly important.  If this bug is not fixed, a corporate user can run
Java applets from outside their corporate network, but can't run any applets
originating internally!!

Comment 5

[edburns]

Nominating for nsbeta2+

Comment 6

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2.  Adding "nsbeta3" keyword 
for consideration of a fix for that milestone. 

Comment 7

[edburns]

ETA 22 July 2000 

Comment 8

[edburns]

Use user_pref("network.proxy.no_proxies_on", "arago.eng.sun.com, 
javaweb.eng.sun.com");

Comment 9

[edburns]

Test code:

  // debug: edburns: test: start
  char *proxy;
  rv = this->FindProxyForURL("http://javaweb.eng.sun.com/", &proxy);
  printf("+++++debug: edburns: javaweb.eng.sun.com: FindProxyForURL: %s\n",
         proxy);
  nsCRT::free(proxy);
  rv = this->FindProxyForURL("http://javaweb/", &proxy);
  printf("+++++debug: edburns: javaweb: FindProxyForURL: %s\n",
         proxy);
  nsCRT::free(proxy);
  rv = this->FindProxyForURL("http://javaweb.eng/", &proxy);
  printf("+++++debug: edburns: javaweb.eng: FindProxyForURL: %s\n",
         proxy);
  nsCRT::free(proxy);
  rv = this->FindProxyForURL("http://www.suck.com/", &proxy);
  printf("+++++debug: edburns: www.suck.com: FindProxyForURL: %s\n",
         proxy);
  nsCRT::free(proxy);
  // debug: edburns: test: end

Comment 10

[edburns]

Attachment: Fix for this bug, first iteration.

Comment 11

[edburns]

av, I'm looking for a= and r= on this.  Thanks.

Comment 12

[edburns]

Checked in fix, marking fixed.

Comment 13

[shrirang khanzode]

marking verified (rubberstamping)