1667716 - Attached vCard displayed if content type is text/x-vcard, but not if it is text/vcard

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P2)

Description

[Geoff Lankow (:darktrojan)]

As the title says, if the attachment's content-type header says text/vcard instead of text/x-vcard, the card is not displayed inline.

Comment 1

[Magnus Melin [:mkmelin]]

Looks like most of https://searchfox.org/comm-central/search?q=text%2Fx-vcard&path= would need adding the synonym.

If we need it. Looks like it's incorrect, and the right mime type is text/x-vcard
https://en.wikipedia.org/wiki/VCard: The Internet media type text/vcard was used incorrectly in some SyncML documents to refer to vCard 3.0, and the example was followed in various implementations.

If it's not a widespread problem, I'd say wontfix.

Comment 2

[Geoff Lankow (:darktrojan)]

It's us sending as text/vcard.

Comment 3

[Magnus Melin [:mkmelin]]

Oh, we definitely need to stop that. https://searchfox.org/comm-central/search?q=text%2Fvcard&path=

Comment 4

[Magnus Melin [:mkmelin]]

Not sure what was on wikipedia at the time. text/vcard is correct and registered: https://tools.ietf.org/html/rfc6350#section-10.1

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

I changed this line https://searchfox.org/comm-central/rev/b972d9ae1bd20536044be70c5bf3670e70b40720/mail/base/content/msgHdrView.js#666 but it seems I need to hook up the VCardMimeConverter (https://searchfox.org/comm-central/rev/b972d9ae1bd20536044be70c5bf3670e70b40720/mailnews/addrbook/modules/VCardUtils.jsm#284) to also handle the text/vcard type.

This seems like the place https://searchfox.org/comm-central/rev/b972d9ae1bd20536044be70c5bf3670e70b40720/mailnews/addrbook/modules/components.conf#29, but I don't understand the .conf file or the fields involved.

If I did change this file, would I need to do a full build rather than an artifact build?

Comment 6

[Magnus Melin [:mkmelin]]

Yeah changing the .conf requires a full build I believe.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Have you got any documentation for the .conf files? I'm not sure what the entries represent.

Comment 8

[Magnus Melin [:mkmelin]]

Best I could find is https://firefox-source-docs.mozilla.org/build/buildsystem/defining-xpcom-components.html

Probably just duplicating the existing text/x-vcard handler replacing text/x-vcard with text/vcard will handle the opening.
The other part is making sure we send out the right thing ourselves as well. But that's in other code.

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1667716 - Extend in-message display of text/x-vcard to text/vcard. r=mkmelin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a7d624ec0a02
Extend in-message display of text/x-vcard to text/vcard. r=mkmelin