1718018 - Send out standard text/vcard Content-Type instead of text/x-vcard

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

According to https://tools.ietf.org/html/rfc6350#section-10.1 (thanks to https://bugzilla.mozilla.org/show_bug.cgi?id=1667716#c4), text/x-vcard is deprecated in favour of text/vcard.

There are a few places that set text/x-vcard (https://searchfox.org/comm-central/search?q=x-vcard&path=). We should probably change all the set types to text/vcard, whilst keeping the text/x-vcard as an alias when reading.

Email Attachments

There is some overlap with Message Composition, in that we inconsistently attach vcards:

• If attached through the Attach -> Personal Card (vCard) menu item, the delivered Content-Type is text/x-vcard.
• If attaching a .vcf or .vcard file manually, the delivered Content-Type is text/vcard.

The former should be text/vcard. I suspect the Personal Card Content-Type comes from https://searchfox.org/comm-central/rev/69d6f790cef76552cd5b132997531252cb575a05/mailnews/compose/src/nsMsgCompose.cpp#1180, although I'm not sure.

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1718018 - Use vcard content types in place of the deprecated x-vcard. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6945a06656ab
Use vcard content types in place of the deprecated x-vcard. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

I think we probably want to go ahead and uplift this to 19 so we don't continue sending an incorrect type for a year. Please request uplifts.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9234692 [details]
Bug 1718018 - Use vcard content types in place of the deprecated x-vcard. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): Deprecation of the x-vcard content type in favour of vcard.
User impact if declined: Sending out a deprecated content type when sharing contacts, and thunderbird's appdata does not advertise itself as handling the vcard content type.
Testing completed (on c-c, etc.): Some unit tests now use the vcard content type and still pass, but no new tests were added.
Risk to taking this patch (and alternatives if risky): Small risk. The handling of vcards in javascript was clear, and it was just a matter of changing the content type from x-vcard to vcard. The mime handling in C++ was less clear, but all such places simply handle both the x-vcard and vcard type.

Comment 5

[Uplift Request]

You need to request beta uplift first, or beta and ESR at the same time. The rules are: A few days on trunk, then on beta, then on ESR. Note that Magnus used the plural form "uplifts".

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9234692 [details]
Bug 1718018 - Use vcard content types in place of the deprecated x-vcard. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): Deprecation of the x-vcard content type in favour of vcard.
User impact if declined: Sending out a deprecated content type when sharing contacts, and thunderbird's appdata does not advertise itself as handling the vcard content type.
Testing completed (on c-c, etc.): Some unit tests now use the vcard content type and still pass, but no new tests were added.
Risk to taking this patch (and alternatives if risky): Small risk. The handling of vcards in javascript was clear, and it was just a matter of changing the content type from x-vcard to vcard. The mime handling in C++ was less clear, but all such places simply handle both the x-vcard and vcard type.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9234692 [details]
Bug 1718018 - Use vcard content types in place of the deprecated x-vcard. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 92.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/68e8173eba51

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9234692 [details]
Bug 1718018 - Use vcard content types in place of the deprecated x-vcard. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/fb273fc4ba65