Closed
Bug 1667750
Opened 4 years ago
Closed 4 years ago
mach bootstrap fails because sentry setup tries to read repo config before username is set up
Categories
(Firefox Build System :: Bootstrap Configuration, defect)
Firefox Build System
Bootstrap Configuration
Tracking
(firefox83 fixed)
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: emilio, Assigned: mhentges)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
broken.png
See the following screenshot from a contributor in #introduction.
This looks broken to me. After setting ui.username in the hgrc file then everything worked.
|
Reporter | |
Comment 1•4 years ago
|
||
Looking at the code this comes from bug 1646832. Can you take a look?
Flags: needinfo?(mhentges)
Regressed by: 1646832
Summary: mach bootstrap fails because sentry setup tries to read repo config before it's set up → mach bootstrap fails because sentry setup tries to read repo config before username is set up
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
|
Assignee | |
Comment 2•4 years ago
|
||
Hmm, weird, it already has behaviour to safely handle the case where ui.username isn't set.
I wonder if your ui.username was using a format that wasn't consistent with the "Full Name <email@domain>" convention.
I'll update this to be more resilient to unexpected formats, thanks for the report!
Flags: needinfo?(mhentges)
|
|
Assignee | |
Comment 3•4 years ago
|
||
If the "ui.username" config option doesn't have a value in the expected
format, assume that the email is unknown instead of throwing an
exception.
|
||
Updated•4 years ago
|
Assignee: nobody → mhentges
Status: NEW → ASSIGNED
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/495109b923c4 safely handle unexpected hg ui.username format r=firefox-build-system-reviewers,rstewart
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•