1667750 - mach bootstrap fails because sentry setup tries to read repo config before username is set up

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: broken.png

See the following screenshot from a contributor in #introduction.

This looks broken to me. After setting ui.username in the hgrc file then everything worked.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Looking at the code this comes from bug 1646832. Can you take a look?

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Hmm, weird, it already has behaviour to safely handle the case where ui.username isn't set.
I wonder if your ui.username was using a format that wasn't consistent with the "Full Name <email@domain>" convention.
I'll update this to be more resilient to unexpected formats, thanks for the report!

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1667750: safely handle unexpected hg ui.username format

If the "ui.username" config option doesn't have a value in the expected
format, assume that the email is unknown instead of throwing an
exception.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/495109b923c4
safely handle unexpected hg ui.username format r=firefox-build-system-reviewers,rstewart

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/495109b923c4