1668629 - Phabricator emails: Reviewer email should not be actionable if revision has planned changes

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect, P2)

Description

[Mitchell Hentges [:mhentges] 🦀]

Right now, if a patch has planned changes (by author) or requested changes (by another reviewer), but you are added as reviewer, then you are told that the email is actionable and that your review is required/requested.

Instead, the "your review is required/requested" should only appear if the patch is "needs review".
Additionally, whenever an event happens that puts the patch back to "needs review" from "needs revision" (such as the only "requested changes" reviewer being removed), the "your review is requred/requested" actionable text should appear as part of that email.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1668629: Reviewers aren't actionable if revision doesn't need review

If a revision doesn't actively need a review (because it's already
approved or because it still needs a change), then reviewers should not
be bugged about "needing to review" the revision.
This patch also coalesces similar reviewer-actionability logic.

Depends on D92294

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: GitHub Pull Request