Closed Bug 1669371 Opened 5 years ago Closed 5 years ago

Phabricator emails: Reviewers can be actionable when revision is reclaimed

Categories

(Conduit :: Phabricator, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mhentges, Assigned: mhentges)

References

Details

(Keywords: conduit-triaged)

Attachments

(2 files)

When a revision is reclaimed with existing reviewers, they should be made aware:

  • If they're actionable
  • Who the other reviewers are and their status (the existing "list reviewers" display)
Assignee: nobody → mhentges
Status: NEW → ASSIGNED
See Also: → 1668629
Blocks: 1667229

The fix here will cause an API breakage.
Between the Phabricator-side fix and the phab-email-side fix being deployed, if a "reclaimed" event is generated, an error will be thrown and the reviewers will not be notified.

Provides additional information in EmailRevisionReclaimed event
so that the client can parameterize emails accordingly.

Depends on D92521

Summary: Phabricator emails: Show reviewers when revision is reclaimed → Phabricator emails: Reviewers can be actionable when revision is reclaimed
Keywords: conduit-triaged
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: