1670317 - Bookmarks menupopup would not scroll and bookmark item would not react until re-open the menupopup.

Status: RESOLVED DUPLICATE of bug 1670452

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: bookmarks menu is broken

If Bookmarks menupopup is overflowed and when the menupopup is displayed at first time,
Bookmarks drop down would not scroll,
Bookmark item would not react.

Steps to reproduce:
(prerequisite)

1. Enable bookmarks toolbar
2. Create a folder in the bookmarks toolbar
3. Create multiple bookmark items in the folder so that the menupopup will be overflowed(scroll-able)

(Steps)

1. Start Browser
2. Click the folder to open menupopup
3. try to scroll the menupopup
   --- the menupopup would not scroll by (mouse wheel/keyboard). BUG!!
   --- No scrollbutton displayed. BUG!!
4. try to open a bookmark in the menupopup by mouse click
   --- the bookmark item would not react(mouse hover/click) BUG!!

(optionally)
5. After re-opening menupopup, the problem will be gone.

Actual Results:
Bookmarks menupopup would not scroll, No scrollbutton displayed.
Bookmark item would not react.

Expected Results:
Bookmarks menupopup should be able to scroll,
Bookmark item would should react.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c8ec11711bb0981f6eb3fe8b95d1d49a41931efd&tochange=98c09e82b3e9728fbfa9204a8b5e3cef676dce76

emilio, your bunch of patch seems to cause the problem. Could you please look into this?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Thanks for filing. Sure, I'll poke.

Is this on windows? I haven't been able to repro on Linux but maybe I'm doing something wrong (or maybe this works in wayland somehow). Is there any chance you could post an screen cast so that I can confirm I'm not doing something dumb?

Thanks a lot as always Alice :)

Comment 2

[Alice0775 White]

Screencast: https://youtu.be/VFXiRseIYdU

Open the menupopup for the first time:
no scroll button display, would not scroll
no tooltip
mouse hover highlight is not consistent(it appears and then disappears)

Re-open the menupopup (video 00:30-):
everything works fine

Comment 3

[Alice0775 White]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Thanks for filing. Sure, I'll poke.

Is this on windows?

Yes, Windows10.

Comment 4

[Alice0775 White]

And I can also reproduce the issue on Ubuntu20.04.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1670317 - Keep flushing layout on popupshowing in places-menupopup. r=Gijs

This is a wallpaper, for now. Without flushing here we end up with a
shrink-to-fit scrollbox, which of course creates no scrollbars.

Whether my patch uncovered a XUL layout bug or just an edge case due to
the transitions that the animate attribute triggers I haven't dug into
quite yet, but we could probably land this in the interim, as it is an
easy fix that doesn't make things worse than they were.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed5f52188003
Keep flushing layout on popupshowing in places-menupopup. r=Gijs

Comment 7

[Alice0775 White]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed5f52188003
Keep flushing layout on popupshowing in places-menupopup. r=Gijs

I tested this bug using autoland opt build, but the issue can be reproduced.
After landing this patch, the problem seems to be depended to timing/CPU load.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

(In reply to Alice0775 White from comment #7)

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed5f52188003
Keep flushing layout on popupshowing in places-menupopup. r=Gijs

I tested this bug using autoland opt build, but the issue can be reproduced.
After landing this patch, the problem seems to be depended to timing/CPU load.

I see, thanks for testing. I'm pretty sure after looking at bug 1670452 that this is just another manifestation of that one.

I've asked sheriffs to back out the wallpaper. Thank you!

Comment 9

[Razvan Maries]

Backed out as requested: https://hg.mozilla.org/integration/autoland/rev/eff8123450daf19894d09154c60d0de8afba7b8e

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Thank you!