1670944 - Can't tab past tab-to-search results when the Urlbar is focused with the keyboard

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Harry Twyford]

STR:

1. Focus the address bar with Accel+L
2. Type enough for a search domain to be autofilled (e.g. "a" to autofill amazon.com). Observe a tab-to-search result is shown.
3. Press tab. The tab-to-search result should be highlighed.
4. Press tab again.

Expected:
The third result is highlighted.

Actual:
The next toolbar item is selected.

Looks like the fix from bug 1666927 didn't fix this. I wonder if that means highlighting tab-to-search results enters full search mode when instead we should preview search mode.

Comment 1

[Marco Bonardo [:mak]]

it seems a bit more than S4 if we get users used to TAB to search, they may keep tabbing, it's not just aesthetic.

Comment 2

[Harry Twyford]

When Tab is pressed, SearchOneOffs nulls its selectedButton. From that call, UrlbarSearchOneOffs calls UrlbarInput.restoreSearchModeState(). Bug 1655486 changed restoreSearchModeState to only restore non-preview search mode. So when Tab is pressed on a result previewing search mode, we actually exit search mode. Then when we get to the UrlbarController Tab handler, allowTabbingThroughResults is false because we are not in search mode, let alone search mode preview.

Comment 3

[Harry Twyford]

Attachment: Bug 1670944 - Allow tabbing past tab-to-search results after focusing the Urlbar with the keyboard. r?adw!

Comment 4

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40f57afc0dce10cf292fdbdb0a0d1953362b2388

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1655486

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4595a3aa2d7a
Allow tabbing past tab-to-search results after focusing the Urlbar with the keyboard. r=mak

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4595a3aa2d7a