Closed Bug 1671301 Opened 4 years ago Closed 4 years ago

TB E10s goal 3: make the tests pass

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(5 files, 2 obsolete files)

Many of the mochitest folders explicitly have E10s disabled, since the CI enables it regardless of the value in all-thunderbird.js. Fortunately a lot of these tests already work fine with E10s enabled (and the code from goals 1 and 2), and a bunch more work with minor changes.

Some of the mozilla-central XPCShell tests are not run on Thunderbird because of E10s.

This bug is about finding all of these tests and making them work.

This first batch of test changes can land now independent of any other changes.

Keywords: leave-open
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/3b482fa94ea0 part 1 - Future-proof some tests for E10s. r=mkmelin

Thunderbird runs content scripts on browsers which are, for the time being, stuck in the parent process. This needs to keep working once we enable extensions in remote processes.

This patch also enables the tests for remote extensions when run as Thunderbird.

Depends on D99174

Blocks: 1681438

Thunderbird loads moz-extension: pages in about:preferences to allow configuration of FileLink extensions. When remote extensions are enabled this will need to be done with a remote browser.

This depends on D99844 and the other E10s work.

This patch changes some WE tests to make them more resilient as we head towards extensions running in a separate process.

The main change is that extensions in the tests each use their own ID if they have one. This reduces the chance of one failing test causing subsequent tests to fail.

I've also tweaked a few places where the tests wait for something to happen, which is going to be more important with multiple processes.

Finally, I've used SpecialPowers.spawn when inspecting the content of documents, regardless of which process they are loaded in.

Comment on attachment 9193375 [details]
Bug 1671301 - Allow Thunderbird to load remote browsers in about:preferences. r?nika

Revision D99844 was moved to bug 1683783. Setting attachment 9193375 [details] to obsolete.

Attachment #9193375 - Attachment is obsolete: true

Comment on attachment 9193376 [details]
Bug 1671301 - Load FileLink provider settings in a remote browser in about:preferences. r?mkmelin

Revision D99845 was moved to bug 1683783. Setting attachment 9193376 [details] to obsolete.

Attachment #9193376 - Attachment is obsolete: true

The aim of this patch is to have the tests run in E10S mode and not fail. Many tests have been disabled (because they fail) and will be addressed in separate patches.

Depends on D99294

Attachment #9194490 - Attachment description: Bug 1671301 - Enable E10S and make the tests pass. → Bug 1671301 - Enable E10S and make the tests pass. r?mkmelin
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/3eceacc7f41e part 2 - Improvements to WebExtensions tests. r=john.bieling DONTBUILD
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/integration/autoland/rev/b0592495878d Changes required for Thunderbird to have remote extensions. r=robwu https://hg.mozilla.org/integration/autoland/rev/8975da71c224 Re-enable test_remoteworker_launch_new_process.js for Thunderbird. r=rpl
Keywords: leave-open
Target Milestone: --- → 86 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0b43c310827b
Enable E10S and make the tests pass. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Regressions: 1687937
No longer regressions: 1687937
Regressions: 1706911
No longer regressions: 1706911
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: