1671401 - Scrollbar on bugzilla page becomes almost invisible on Windowsx64+ Intel with "widget.disable-native-theme-for-content = true"

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Mayank Bansal]

Use nightly on Windowsx64+ Intel

Set widget.disable-native-theme-for-content = true

Open https://bugzilla.mozilla.org/buglist.cgi?resolution=---&resolution=DUPLICATE&chfieldto=Now&chfield=%5BBug%20creation%5D&query_format=advanced&chfieldfrom=24h&product=Core&list_id=15452820

ER: Scrollbar is visible
AR: Scrollbar becomes invisible

Comment 1

[Mayank Bansal]

2020-10-15T19:22:10.756000: DEBUG : Found commit message:
Bug 1669368 - Use LookAndFeelCache to pass Gtk theme-derived scrollbar colors to content processes. r=spohl

Differential Revision: https://phabricator.services.mozilla.com/D93467

2020-10-15T19:22:10.756000: DEBUG : Did not find a branch, checking all integration branches
2020-10-15T19:22:10.756000: INFO : The bisection is done.
2020-10-15T19:22:10.771000: INFO : Stopped

Comment 2

[Darkspirit]

Gnome Xwayland, Debian Testing
Scrollbar thumb is invisible until hovered.

Edit: Breeze theme. (Gnome with Plasma-style window buttons.)

Comment 3

[Cameron McCormack (:heycam)]

Darkspirit, what Gtk theme are you using on Linux?

Definitely there wasn't an intention to change the colors that were being used on Windows, though.

Comment 4

[Cameron McCormack (:heycam)]

(Thanks you answered in an edit.)

Comment 5

[Cameron McCormack (:heycam)]

This one? https://www.gnome-look.org/p/1335436/

Comment 6

[Darkspirit]

(I answered only seconds before you asked. Sorry :D)
I must have seen this article: https://www.computerbase.de/2016-07/linux-gnome-mit-breeze-im-kde-look/
Download https://github.com/dirruk1/gnome-breeze/archive/master.zip, extract it to ~/.themes (example path: ~/.themes/gnome-breeze-master/README.md), select it with Gnome Tweak Tool.

Comment 7

[Cameron McCormack (:heycam)]

I have a patch for the problem on Windows, but I can't reproduce the issue with the Breeze theme.

Comment 8

[Cameron McCormack (:heycam)]

Attachment: screen shot

This is what Firefox looks like for me when I use the Breeze theme (not the dark one), when the scrollbar isn't hovered over.

Comment 9

[Cameron McCormack (:heycam)]

Attachment: screen shot (hovering)

And hovered over the thumb. The colors do match what I see in other applications (e.g. gedit), though we are drawing them with an Adwaita-like shape rather than what the Breeze theme itself uses.

Comment 11

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff3d30c7d492fb07f4009ad73eab074b8e88b0d4 for the Windows fix.

Comment 12

[Cameron McCormack (:heycam)]

Darkspirit, I see that the theme has different variants for a few different Gtk versions, and some of them use images. Although I would've thought that Debian testing had a new enough Gtk to end up with the gtk-3.20 version of the theme, which uses only solid colors.

Bug 1671304 should detect themes with images that we can't handle, and fall back to using some pre-defined colors.

Comment 13

[Cameron McCormack (:heycam)]

Attachment: Bug 1671401 - Use separate Scrollbar and ThemedScrollbar ColorIDs.

Otherwise on Windows, we have a ColorID::Scrollbar but not any of the other scrollbar part
colors, and the Windows-provided value for Scrollbar doesn't work well
with the default values for the other scrollbar parts that come from the
non-native theme.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67cc13c5744b
Use separate Scrollbar and ThemedScrollbar ColorIDs. r=spohl

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/67cc13c5744b