1672401 - PiP description is displayed incorrectly on whereby.com

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2020-10-21_17h20_03.png

Affected versions:

Nightly 84.0a1

Tested on:

Ubuntu 18.04, Windows 10

Steps:

1. Launch Firefox Nightly with new profile and go to https://whereby.com
2. Join a meeting.
3. Click on the PiP icon.

Actual result:

The PiP description is displayed incorrectly (is displayed like in RTL).

Expected result:

The PiP description should be displayed accordingly like in any video.

Note: The PiP icon is not displayed in Beta 83 and Release 82 on whereby.com

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'm assuming they are doing something to mirror the video by applying transform: scaleX(-1)?

Can we set transform: initial !important on the PiP CSS?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Yeah, I think generally transform: scaleX(-1) is how this works. Unfortunately, setting transform: initial !important doesn't work on child elements for something set to scaleX(-1);:

https://jsbin.com/duyuzebewu/edit?html,css,output

We can, however, maybe used the privileged getTransformToViewport method here: https://searchfox.org/mozilla-central/rev/dbced93f1c57942501c23d4633d01ce59d9087a1/dom/webidl/Element.webidl#169. If we call that on the <video>, then if it (or one of its ancestors) is transformed such that the .a field on the DOMMatrix is -1, then we should set transform: scaleX(-1) on the UAWidget, perhaps when the mouse first moves over the video.

Comment 3

[Chris Jackson]

Attachment: Bug 1672401 - Picture-in-Picture description is displayed incorrectly on whereby.com. r?mconley,gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ecbca0ad84f
Picture-in-Picture description is displayed incorrectly on whereby.com. r=mconley,Gijs

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ecbca0ad84f

Comment 8

[Mathew Hodson]

Attachment: Beta screenshot

This happens for me on Beta 83.0b10 build ID 20201108174701

Comment 9

[Mathew Hodson]

This happens for me on Beta 83 build

Comment 10

[Mathew Hodson]

And has existed longer according to the duplicate bugs like bug 1592909.

Comment 11

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 84.0a1 (2020-11-09) (build id: 20201109215349).