1672419 - WebRTC system tray context menu is positioned away from the icon with high DPI

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Itiel]

STR:

1. Set DPI to anything above 100%
2. Open https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/#8135501154568966
3. Click "Share you screen" and select a window
4. Right click the system icon tray

AR:
bug 1669649 comment 8

ER:
The context menu should be positioned where the mouse right clicked.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1672419 - Make sure SystemStatusBar popup menus appear in the right spot regardless of device scaling. r?mhowell

Comment 2

[Daniel Bodea [:danibodea]]

I can confirm this issue's reproduction on Windows 10 with Nightly v84.0a1 and Beta v83.0b4. Modifying the Display Scaling to any other option than 100% will improperly position the context menu incorrectly.

Comment 3

[Daniel Bodea [:danibodea]]

I would think that this issue deserves a severity promotion considering that a lot of users use scaling on their computers. Please revert if you think this is incorrect.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f36a4e0cb84c
Make sure SystemStatusBar popup menus appear in the right spot regardless of device scaling. r=mhowell

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f36a4e0cb84c

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9183027 [details]
Bug 1672419 - Make sure SystemStatusBar popup menus appear in the right spot regardless of device scaling. r?mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Users with high DPI display settings on Windows will find that the WebRTC device indicator menus are positioned strangely upon opening.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Be using Windows with a camera and microphone connected
2. Visit https://permission.site/, and click on "Camera + Microphone", and allow Firefox to share the camera and microphone devices.
3. Find the camera and/or microphone device indicators in the Windows system tray. They might be collapsed into the overflow area of the tray.
4. Click on either of those icons.
5. Repeat using different DPI settings

ER:

A menu should appear close to the icon, regardless of DPI setting.

Note that changing DPI settings in Windows can be done by following these instructions: https://support.corel.com/hc/en-us/articles/115001485408-Display-Options-How-to-change-DPI-Scaling-Level-for-displays-in-Windows-10-

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're changing some positioning calculations in a very isolated part of the code base, using well-understood mechanisms.
• String changes made/needed: None.

Comment 7

[Daniel Bodea [:danibodea]]

I can verify this fix in Nightly v84.0a1 from 29-10-2020. Thank you!

Waiting for possible uplifts to verify.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9183027 [details]
Bug 1672419 - Make sure SystemStatusBar popup menus appear in the right spot regardless of device scaling. r?mhowell

Verified on nightly, approved for 83 beta 6, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c08b844f9e9

Comment 10

[Mihai Boldan, Desktop QA [:mboldan]]

Added qe+ for Beta verification.

Comment 11

[Daniel Bodea [:danibodea]]

I have verified this fix in Beta v83.0b6 on Windows 10. Thank you.