Closed Bug 1663784 Opened 6 months ago Closed 5 months ago

Add shared device indicators in the Windows notification area

Categories

(Firefox :: Site Permissions, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
83 Branch
Tracking Status
firefox83 --- verified
firefox84 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

We have something similar on macOS. We should try to re-use much of the same code to achieve the same effect on Windows and Linux.

Severity: -- → N/A
Priority: -- → P1
Attachment #9174965 - Attachment description: Bug 1663784 - [WIP] Implement basic nsISystemStatusBar service for Windows. r?mhowell → Bug 1663784 - Implement basic nsISystemStatusBar service for Windows. r?mhowell
Attachment #9174966 - Attachment description: Bug 1663784 - [WIP] Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r?pbz → Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r?pbz
Attachment #9175299 - Attachment description: Bug 1663784 - [WIP] Generalize nsIconLoaderService so other platforms can use it. r?spohl! → Bug 1663784 - Generalize nsIconLoaderService so other platforms can use it. r?spohl!
Attachment #9175345 - Attachment description: Bug 1663784 - [WIP] Windows implementation of IconLoader. r?mhowell → Bug 1663784 - Add Windows platform support for IconLoader. r?mhowell
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e85a84aaa45f
Rename mozilla.org/widget/macsystemstatusbar to mozilla.org/widget/systemstatusbar. r=spohl
See Also: → 1665334

Windows is only in scope for this bug. I'll split one out for Linux.

Summary: Add shared device indicators in the Windows and Linux notification areas → Add shared device indicators in the Windows notification area
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ee61c4a6bc8
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/d1faf309c9d0
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/a737df82383a
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/428926be2268
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/97be0dd0742d
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53a57a5b60d3
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/9e5267b83d94
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/282d763360a2
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/ddfbe96735f3
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/e812f197f225
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/964a2fffbe6a
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/6125eabcda06
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/8570c8e5de48
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/54ccb91463a8
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/3b98ecead609
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8
Flags: needinfo?(mconley)

Mike, should we add this enhancement to our release notes? Thanks

Flags: needinfo?(mconley)
See Also: → 1669649

I think this can be wrapped in with the notice about the new indicator from bug 1665490 as well.

Flags: needinfo?(mconley)
Blocks: 1672419
Flags: qe-verify+
QA Contact: daniel.bodea

I can confirm this implementation on Windows 10 and Windows 7 with Nightly v84.0a1 and Beta v83.0b4.

Apart from the DPI bug above, nothing else was found. Please reopen if you consider that the blocker should be fixed before verification.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.