1663784 - Add shared device indicators in the Windows notification area

Status: VERIFIED FIXED

(Firefox :: Site Permissions, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We have something similar on macOS. We should try to re-use much of the same code to achieve the same effect on Windows and Linux.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Rename mozilla.org/widget/macsystemstatusbar to mozilla.org/widget/systemstatusbar. r?spohl

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Implement basic nsISystemStatusBar service for Windows. r?mhowell

Depends on D89786

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r?pbz

Depends on D89787

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Generalize nsIconLoaderService so other platforms can use it. r?spohl!

Depends on D89788

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Add Windows platform support for IconLoader. r?mhowell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e85a84aaa45f
Rename mozilla.org/widget/macsystemstatusbar to mozilla.org/widget/systemstatusbar. r=spohl

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e85a84aaa45f

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Windows is only in scope for this bug. I'll split one out for Linux.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1663784 - Make StatusBarEntry and IconLoader classes work with the cycle collector. r?mccr8

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee61c4a6bc8
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/d1faf309c9d0
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/a737df82383a
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/428926be2268
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/97be0dd0742d
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8

Comment 11

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2Ccross%2Ccompiled%2Cshippable%2Copt%2Cprofile-guided%2Coptimization%2Cbuilds%2Cinstrumented-build-macosx64-shippable%2Fopt%2Cinstr&revision=4a035c0339f835b121d9bbeb526fe4527f118836&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317083966&repo=autoland&lineNumber=40784
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317083954&repo=autoland&lineNumber=27167

Backout: https://hg.mozilla.org/integration/autoland/rev/0cab42ee629937e83b3ca57fff07902293b99433

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53a57a5b60d3
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/9e5267b83d94
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/282d763360a2
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/ddfbe96735f3
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/e812f197f225
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8

Comment 13

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_all_files_referenced.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/04f056552f44c6e051d65793b209c9840be0b7ce
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317211888&repo=autoland&lineNumber=1639

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/964a2fffbe6a
Implement basic nsISystemStatusBar service for Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/6125eabcda06
Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/8570c8e5de48
Generalize nsIconLoaderService so other platforms can use it. r=mstange
https://hg.mozilla.org/integration/autoland/rev/54ccb91463a8
Add Windows platform support for IconLoader. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/3b98ecead609
Make StatusBarEntry and IconLoader classes work with the cycle collector. r=mccr8

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/964a2fffbe6a
https://hg.mozilla.org/mozilla-central/rev/6125eabcda06
https://hg.mozilla.org/mozilla-central/rev/8570c8e5de48
https://hg.mozilla.org/mozilla-central/rev/54ccb91463a8
https://hg.mozilla.org/mozilla-central/rev/3b98ecead609

Comment 16

[Pascal Chevrel:pascalc]

Mike, should we add this enhancement to our release notes? Thanks

Comment 17

[Mike Conley (:mconley) (:⚙️)]

I think this can be wrapped in with the notice about the new indicator from bug 1665490 as well.

Comment 18

[Daniel Bodea [:danibodea]]

I can confirm this implementation on Windows 10 and Windows 7 with Nightly v84.0a1 and Beta v83.0b4.

Apart from the DPI bug above, nothing else was found. Please reopen if you consider that the blocker should be fixed before verification.