1672792 - Indicate shortcuts key to Alt > View > Toolbars > "Bookmarks Toolbar"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Alice0775 White]

Attachment: Screenshot Nightly84.0a1

Steps to reproduce:

1. Alt > View > Toolbars

Actual results:
Nothing indicated shortcut key

Expected results:
Menu should be 'Bookmarks Toolbar Ctrl+Shift+B'

Comment 1

[Mark Banner (:standard8)]

Gijs, can you take a look at this? I'm not sure if this could be done with the new sub-menu. Maybe a question for UX?

Comment 2

[:Gijs (he/him)]

This isn't easily possible because you can't have shortcut references on a submenu. We'd need to change our menu item bindings, and even once we do that I have no idea what happens on macOS.

We could more easily display the shortcut on "always" or "never" entries in the submenu, depending on which of those the shortcut will toggle to? :-\

Jared, what do you think?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, I think that is something we can do. Maybe a bit odd to see the shortcut jump between the two items but that won't be so visible unless the user is looking for it.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1672792 - Indicate shortcuts key to Alt > View > Toolbars > Bookmarks Toolbar menu.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9c622a95803
Indicate shortcuts key to Alt > View > Toolbars > Bookmarks Toolbar menu. r=mtigley

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d9c622a95803

Comment 7

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified on Fx 84.0b4 on Windows 10 x64, Ubuntu 18.04 and macOS 10.15.