Closed Bug 1328637 Opened 4 years ago Closed 5 months ago
Personal (bookmarks) toolbar lacks a keyboard shortcut to show/hide the bar (ideally same as Chrome)
47 bytes, text/x-phabricator-request
|Details | Review|
Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"
47 bytes, text/x-phabricator-request
|Details | Review|
Something that bothers me is the lack of keyboard shortcut to show/hide the personal toolbar in Firefox. On Chrome this is CTRL+SHIFT+B and I think it would be nice to have the same shortcut as they have. I am currently using an unmaintained 2013 extension (https://addons.mozilla.org/fr/firefox/addon/show-hide-bookmarks-toolbar/) to get that feature but I feel that the keyboard shortcut should be built in Firefox. Thanks
What should happen with the library shortcut, which is what accel-shift-b currently points to?
Component: Toolbars and Customization → Bookmarks & History
On my Linux box, en-US or fr loclaes, the library shortcut is ctrl+B so there is no conflict. I don't know if the locale of the OS and keyboard default impact this. Obviously I am not asking for an existing shortcut to be replaced, if we can't have the same shortcut as Chrome that's a minor point, that's why I said it would be nice to have the same shortcut, not that it must be the same as what Chrome uses.
On both OS X and Windows, accel-b opens the bookmarks *sidebar*, and accel-shift-b opens the library. On my Linux (Ubuntu) VM, using m-c compiled or Ubuntu's packaged version of Firefox, ctrl-b opens the sidebar, not the library. I'm not sure why you're seeing something else. It seems on Linux (at least for me) the library shortcut is ctrl-shift-o. It looks like the library shortcut is different on GTK compared to everywhere else, presumably (maybe at the time, and not anymore) because of a conflict with the window manager or something. https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#306-308 In any case, both accel-b and accel-shift-b are taken on Windows and OS X. Can you elaborate on when this shortcut is useful and/or why it'd be better than the sidebar shortcut, given we can't have a "nice"/obvious shortcut for the bookmarks bar that doesn't conflict with existing shortcuts (on all OSes)? I suppose we could in principle use ctrl-shift-b on GTK (if it's really not taken (anymore)) and accel-shift-o on Windows and OSX, but that feels a bit naff. (For background: I have the bar permanently visible, and I'm not sure in what circumstances you'd want it hidden if you use it regularly. It's also not keyboard-accessible, so you'd need to keyboard shortcut and then mouse over when you show it. Almost feels like a toolbar button might be more useful, maybe? But I guess I'm just not following how you use it :-) )
I don't have the bar visible permanently because it takes up visual/reading space and generally speaking It makes the UI feel cluttered. I store there a few bookmarks I use on a daily basis (for example the status update pages for the team meetings I participate in which are all at the end of the European day, so no use for these bookmarks to be visible constantly) but not often enough to have that bar open all the time. The sites I use all the time are not bookmarks but pinned tabs. Opening the library sidebar is less agreable visually because it causes all of the content on the page to be narrowed which I find disturbing especially for sites that will reorganize the page content because of the narrowed space for content, the library sidebar also contains other content than the personal toolbar as well as a search bar and forces scanning the bookmarks from top to down and not from left to right which I do faster.
Note that maybe we could change the shortcut on Linux for the Library window to be CTRL+SHIFT+B if there is no reason today to have a different shortcut on Linux. That could result in: Library Window: Ctrl+Shift+b Library Sidebar: Ctrl+b Personal Toolbar: Ctrl+Shift+o This way the Library Window shortcut is unified across platforms and we now can use ctrl+shift+o for the new shortcut.
For what it's worth, I'd like to emphatically second the motion for Ctrl/Cmd+Shift+O as the Library shortcut, and Ctrl/Cmd+Shift+B for Show/Hide Bookmarks Bar. This should work great on all three platforms. As far as use cases for having the shortcut: as another commenter noted, hiding the bookmark bar helps me eliminate distraction and increase vertical space for content. Even *if* the bookmarks bar isn't keyboard-accessible, it'd still be nice to have a hotkey for quick access. I'm personally having to rely on bookmarklets for several services that don't have functional Firefox extensions anymore. Once upon a time there was a pretty good extension (https://addons.mozilla.org/en-US/firefox/addon/hide-bookmarksbar/) that allowed you to show/hide the bookmarks bar with a keyboard shortcut, but it's since fallen by the wayside. Not sure to what extent the WebExtensions API allows you to manipulate the browser UI (apart from tabs), but I'm guessing it's very limited, and probably the extension will never be updated. Furthermore, and I think most importantly, using "Ctrl+Shift+B" is no longer a proper mnemonic for the Library, because more things have been moved/consolidated into that window over the years besides just bookmarks. It's like another "File... Open" dialog of sorts, and so I'm really in favor of assigning <modifiers>+"O" as in "Open" to that. On the other hand, "Ctrl+Shift+B" *is* a great mnemonic for "Bookmarks Bar". I think it's a win-win. :)
Oh, that was never the motion. I guess I read what I wanted it to read. And actually, <accel>+Shift+B *is* a good mnemonic for "Show All Bookmarks," so I take that back. Anyway, respectfully submitted. I'd also like to point out that unless you are a long-time user of the "Show All Bookmarks" shortcut, or know the "Alt" key trick to display the menus, or have a Mac (where there's a global menu bar), the keyboard shortcut for "Show All Bookmarks" isn't even exposed in the new UI unless you go <menu> -> Library -> Bookmarks, and then all the way at the bottom. That's pretty buried, and Ctrl/Cmd+B is way easier nowadays. I feel like the user impact to changing it to <accel>+Shift+O on potentially two out of three platforms is pretty minimal, if the end result is better cross-platform consistency (and feature parity with Chrome and Opera with respect to the show/hide bookmarks bar shortcut).
The most important use-case for this I see is for creating screenshots of websites for sharing (semi)publicly. I don't want to share all my top-level bookmarks/folders on these screenshots and enabling disabling the bar via mouse/menu is cumbersome for this. Ctrl+Shift+B would also be my preferred variant since I'm used to that from other browsers. If that "global" shortcut change is too much to ask, an option in about:flags would also be fine for me.
Now my proposal: Ctrl + Shift + O seems ok to me, yet Ctrl + Alt + B would continue the existent keyboard shortcuts trend for bookmarks. The first three following shortcuts are the currently used, and the 4th is the proposed as the last piece of the puzzle we missed: Ctrl + Shift + B -> displays the bookmark Library, Ctrl + B -> for the bookmarks left-side navigation pane. Alt + B -> displays the bookmarks from the menu. Ctrl + Alt + B -> new shortcut for the bookmarks horizontal toolbar. Also, Ctrl + Alt keys form a horizontal bar, which resembles the horizontal toolbar (it might serve as a mnemonic).
Summary: Personal toolbar lacks a keyboard shortcut to show/hide the bar (ideally same as Chrome) → Personal (bookmarks) toolbar lacks a keyboard shortcut to show/hide the bar (ideally same as Chrome)
Assignee: nobody → tigleym
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/94b3b8f32af5 Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,fluent-reviewers
Depends on: 1675549
Flags: needinfo?(mtigley) → needinfo?(alin.ilea)
Flags: needinfo?(alin.ilea) → needinfo?(gijskruitbosch+bugs)
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.