1328637 - Personal (bookmarks) toolbar lacks a keyboard shortcut to show/hide the bar (ideally same as Chrome)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P1)

Description

[Pascal Chevrel:pascalc]

Something that bothers me is the lack of keyboard shortcut to show/hide the personal toolbar in Firefox.

On Chrome this is CTRL+SHIFT+B and I think it would be nice to have the same shortcut as they have.

I am currently using an unmaintained 2013 extension (https://addons.mozilla.org/fr/firefox/addon/show-hide-bookmarks-toolbar/) to get that feature but I feel that the keyboard shortcut should be built in Firefox.

Thanks

Comment 1

[:Gijs (he/him)]

What should happen with the library shortcut, which is what accel-shift-b currently points to?

Comment 2

[Pascal Chevrel:pascalc]

On my Linux box, en-US or fr loclaes, the library shortcut is ctrl+B so there is no conflict. I don't know if the locale of the OS and keyboard default impact this. Obviously I am not asking for an existing shortcut to be replaced, if we can't have the same shortcut as Chrome that's a minor point, that's why I said it would be nice to have the same shortcut, not that it must be the same as what Chrome uses.

Comment 3

[:Gijs (he/him)]

On both OS X and Windows, accel-b opens the bookmarks *sidebar*, and accel-shift-b opens the library. On my Linux (Ubuntu) VM, using m-c compiled or Ubuntu's packaged version of Firefox, ctrl-b opens the sidebar, not the library. I'm not sure why you're seeing something else. It seems on Linux (at least for me) the library shortcut is ctrl-shift-o.

It looks like the library shortcut is different on GTK compared to everywhere else, presumably (maybe at the time, and not anymore) because of a conflict with the window manager or something.

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#306-308

In any case, both accel-b and accel-shift-b are taken on Windows and OS X.


Can you elaborate on when this shortcut is useful and/or why it'd be better than the sidebar shortcut, given we can't have a "nice"/obvious shortcut for the bookmarks bar that doesn't conflict with existing shortcuts (on all OSes)?

I suppose we could in principle use ctrl-shift-b on GTK (if it's really not taken (anymore)) and accel-shift-o on Windows and OSX, but that feels a bit naff.

(For background: I have the bar permanently visible, and I'm not sure in what circumstances you'd want it hidden if you use it regularly. It's also not keyboard-accessible, so you'd need to keyboard shortcut and then mouse over when you show it. Almost feels like a toolbar button might be more useful, maybe? But I guess I'm just not following how you use it :-) )

Comment 4

[Pascal Chevrel:pascalc]

I don't have the bar visible permanently because it takes up visual/reading space and generally speaking It makes the UI feel cluttered. I store there a few bookmarks I use on a daily basis (for example the status update pages for the team meetings I participate in which are all at the end of the European day, so no use for these bookmarks to be visible constantly) but not often enough to have that bar open all the time. The sites I use all the time are not bookmarks but pinned tabs.

Opening the library sidebar is less agreable visually because it causes all of the content on the page to be narrowed which I find disturbing especially for sites that will reorganize the page content because of the narrowed space for content, the library sidebar also contains other content than the personal toolbar as well as a search bar and forces scanning the bookmarks from top to down and not from left to right which I do faster.

Comment 5

[Pascal Chevrel:pascalc]

Note that maybe we could change the shortcut on Linux for the Library window to be CTRL+SHIFT+B if there is no reason today to have a different shortcut on Linux. That could result in:
Library Window: Ctrl+Shift+b
Library Sidebar: Ctrl+b
Personal Toolbar: Ctrl+Shift+o

This way the Library Window shortcut is unified across platforms and we now can use ctrl+shift+o for the new shortcut.

Comment 6

[Kevin Ernst]

For what it's worth, I'd like to emphatically second the motion for Ctrl/Cmd+Shift+O as the Library shortcut, and Ctrl/Cmd+Shift+B for Show/Hide Bookmarks Bar. This should work great on all three platforms.

As far as use cases for having the shortcut: as another commenter noted, hiding the bookmark bar helps me eliminate distraction and increase vertical space for content. Even *if* the bookmarks bar isn't keyboard-accessible, it'd still be nice to have a hotkey for quick access. I'm personally having to rely on bookmarklets for several services that don't have functional Firefox extensions anymore.

Once upon a time there was a pretty good extension (https://addons.mozilla.org/en-US/firefox/addon/hide-bookmarksbar/) that allowed you to show/hide the bookmarks bar with a keyboard shortcut, but it's since fallen by the wayside. Not sure to what extent the WebExtensions API allows you to manipulate the browser UI (apart from tabs), but I'm guessing it's very limited, and probably the extension will never be updated.

Furthermore, and I think most importantly, using "Ctrl+Shift+B" is no longer a proper mnemonic for the Library, because more things have been moved/consolidated into that window over the years besides just bookmarks. It's like another "File... Open" dialog of sorts, and so I'm really in favor of assigning <modifiers>+"O" as in "Open" to that.

On the other hand, "Ctrl+Shift+B" *is* a great mnemonic for "Bookmarks Bar". I think it's a win-win. :)

Comment 7

[Kevin Ernst]

Oh, that was never the motion. I guess I read what I wanted it to read. And actually, <accel>+Shift+B *is* a good mnemonic for "Show All Bookmarks," so I take that back. Anyway, respectfully submitted.

I'd also like to point out that unless you are a long-time user of the "Show All Bookmarks" shortcut, or know the "Alt" key trick to display the menus, or have a Mac (where there's a global menu bar), the keyboard shortcut for "Show All Bookmarks" isn't even exposed in the new UI unless you go <menu> -> Library -> Bookmarks, and then all the way at the bottom. That's pretty buried, and Ctrl/Cmd+B is way easier nowadays.

I feel like the user impact to changing it to <accel>+Shift+O on potentially two out of three platforms is pretty minimal, if the end result is better cross-platform consistency (and feature parity with Chrome and Opera with respect to the show/hide bookmarks bar shortcut).

Comment 8

[juliocmdsilva]

This feature is definitely a convenience. I see myself constantly pressing CTRL+SHIFT+B to hide bookmarks and stumble upon an extended view of the elements I want to hide (since as of this writing the shortcut pops up the Favorites window). Layout manipulations as common as this should be accessible in a straightforward way, and even finding the Hide option in the menu can be misleading...

Comment 9

[Steve]

It's definitely an oversight, I'd like to see it fixed, too.

Comment 10

[Steve]

The lack of votes tells me that the vote section starting hidden is a rather bad idea here - if I didn't recall that there was a voting possible, I'd never have guessed it.

Comment 11

[vinnie]

Add me to the list.  I often need to do screenshots in FF for my customers, but don't want to have my personal bookmarks showing when I do.  Yet, I need to keep it visible for my own usage.  Toggling the bookmark bar's visibility should be available by a keyboard shortcut.

Comment 12

[thedonquixotic]

I would like to throw in my support for this too. Also I would vote, but I can't actually see where the vote buttons are in Bugzilla. Where is it?

Comment 13

[paul.klingelhuber]

The most important use-case for this I see is for creating screenshots of websites for sharing (semi)publicly. I don't want to share all my top-level bookmarks/folders on these screenshots and enabling disabling the bar via mouse/menu is cumbersome for this.
Ctrl+Shift+B would also be my preferred variant since I'm used to that from other browsers.

If that "global" shortcut change is too much to ask, an option in about:flags would also be fine for me.

Comment 14

[vinnie]

(In reply to paul.klingelhuber from comment #13)
> The most important use-case for this I see is for creating screenshots of
> websites for sharing (semi)publicly. I don't want to share all my top-level
> bookmarks/folders on these screenshots and enabling disabling the bar via
> mouse/menu is cumbersome for this.

This is exactly my situation.  When I am communicating with a customer using Firefox, I want to send a screenshot of what I'm referring to using the same browser they are using, but I don't want them to see my bookmark bar shortcuts.  Ctrl+Shift+B (or a customizable keyboard option) would be optimal to make this truly convenient for temporarily hiding the bookmark bar.

Comment 15

[gavreh]

I am trying to switch to Firefox but this feature is a must-have. Creating screenshots of websites and doing screen-shares without everyone seeing your bookmarks bar is the use case for me - very important.

Ctrl+Shift+B would be the best option to keep consistent with other browsers.

Comment 16

[jusore]

I don't know why the keyboard shortcut to show/hide the personal toolbar in Firefox is missing. It's so useful.

Comment 17

[Mart]

Metoo comment (explained):
I returned to use Firefox mainly for its bookmarks system (also new vers started faster), but displaying the bookmarks toolbar with Alt + V + T + B is a pain in the fingers and in time....
I save libraries and several webs that I organized with details and annotations in the Bookmarks Menu. Yet the Bookmarks Menu is more convenient for very frequently used bookmarks or those I want to have present (/see constantly). Also they take less space and in a different layout than the bookmarks... 
Please Mozilla coders take care of those strengths that can make Firefox better than Chrome and others... Making a keyboard shortcut is small step for a man but a big one for humanity!

Comment 18

[Mart]

Now my proposal: 

Ctrl + Shift + O seems ok to me, yet  Ctrl + Alt + B would continue the existent keyboard shortcuts trend for bookmarks. The first three following shortcuts are the currently used, and the 4th is the proposed as the last piece of the puzzle we missed:

Ctrl + Shift + B  -> displays the bookmark Library, 
Ctrl + B          -> for the bookmarks left-side navigation pane.
Alt + B           -> displays the bookmarks from the menu. 
Ctrl + Alt + B    -> new shortcut for the bookmarks horizontal toolbar.

Also, Ctrl + Alt keys form a horizontal bar, which resembles the horizontal toolbar (it might serve as a mnemonic).

Comment 19

[Graham Perrin]

(In reply to Mart from comment #18)

… Ctrl + Shift + O seems ok …

Mozilla bug 1527337 - The established keyboard shortcut Ctrl+Shift+O for 'Show All Bookmarks' is not documented in Mozilla help for keyboard shortcuts

– not documented, but (through actual use of Firefox) people have become accustomed to the shortcut.

For this bug 1328637: at the time of writing I don't know what to suggest. Sorry.

Comment 20

[Graham Perrin]

(In reply to Mart from comment #18)

… Ctrl + Shift + B -> displays the bookmark Library, …

Documented by Mozilla but truly, this shortcut is non-effective with actual use of Firefox 65.0 on FreeBSD-CURRENT and Firefox 65.0 in Lubuntu.

On which OS – if any – does Ctrl-Shift-B have any effect in any recent release of Firefox?

Comment 21

[:Gijs (he/him)]

(In reply to Graham Perrin from comment #20)

On which OS – if any – does Ctrl-Shift-B have any effect in any recent release of Firefox?

Windows. Mac also has cmd-shift-b. See also comment #3.

Comment 22

[:Gijs (he/him)]

ctrl-alt combinations are not feasible on Windows. See bug 1438308 comment 2 to 4.

Comment 23

[Graham Perrin]

Thanks. Apologies for any confusion.

Now at https://bugzilla.mozilla.org/show_bug.cgi?id=1527337#c1

… I should treat this bug as a Tier-2 Knowledge Base content issue; …

Comment 24

[Graham Perrin]

Sorry, Tier-3. I forgot, FreeBSD is Tier-3.

Comment 27

[namikdelilovic]

Not sure if this is the right place to also make this feature request. This shortcut is mostly needed to make screenshots without exposing personal bookmarks.

Comment 28

[James Moriarty]

Same use case here as well. Hiding personal bookmarks when taking screenshots or screen sharing.

Comment 29

[chagelid]

+1. I use this a lot in Chrome both for removing minimizing visual clutter when reading and also when taking screenshots. I would prefer ctrl + shift + b to mimic chrome but would be happy with any shortcut.

Comment 30

[hx48jai2]

Hiding/showing the bookmark toolbar is easily done by right-clicking the empty space between the address bar and the extension icons, and checking/unchecking the "Bookmarks toolbar" option.

Comment 31

[thedonquixotic]

(In reply to hx48jai2 from comment #30)

Hiding/showing the bookmark toolbar is easily done by right-clicking the empty space between the address bar and the extension icons, and checking/unchecking the "Bookmarks toolbar" option.

This doesn't really address the requested user experience issue.

Comment 32

[kris]

How is this still not a thing in 2020?

Comment 33

[davetcoleman]

If a patch was proposed for these changes, would they be accepted? What would be the process to get support to get them accepted?

It seems to me the summary of this thread is "I want Firefox to act just a little bit more like Chrome", to which I vehemently agree, and I am curious what the general philosophy to that sentiment is in this community?

Comment 34

[Asif Youssuff]

(In reply to davetcoleman from comment #33)

If a patch was proposed for these changes, would they be accepted? What would be the process to get support to get them accepted?

It seems to me the summary of this thread is "I want Firefox to act just a little bit more like Chrome", to which I vehemently agree, and I am curious what the general philosophy to that sentiment is in this community?

See here: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction

This has already been prioritized as a P3 (backlog) item, so a good patch would be accepted (after code review, of course). The reporter of the bug is a Mozilla employee, so I think you are good to start - you can ask Pascal for help if you like (or he will direct you to someone who can help).

Comment 35

[:Gijs (he/him)]

(In reply to davetcoleman from comment #33)

If a patch was proposed for these changes, would they be accepted?

Which changes, exactly? As far as I can tell nobody has come up with a realistic shortcut to use here (see earlier comments), without removing either the shortcut for the sidebar or for the library window. If you're proposing to do either of those, it'd be worth talking to a UX person to make sure that's acceptable, before putting in the work of writing a patch...

Comment 36

[davetcoleman]

I'm a first-timer to Firefox development, though certainly not to contributing to open source C++ projects. I got the build from source running last night and grep'ed the code for an hour, but couldn't find where OS-specific keybindings are defined. I'm probably not the right person to champion a patch, in hindsight.

I was searching where the Ctrl-Shift-B vs Ctrl-Shift-O bindings were defined and was going to propose we unify them as Ctrl-Shift-O, as some have proposed in this discussion thread. This would make room for Ctrl-Shift-B to allow the booksmark toolbar to be shown/hidden.

Having a UX person weight in sounds like a good idea, though no doubt this behavior was already approved by the Chrome team's UX people long ago.

Comment 37

[:Gijs (he/him)]

(In reply to davetcoleman from comment #36)

I'm a first-timer to Firefox development, though certainly not to contributing to open source C++ projects. I got the build from source running last night and grep'ed the code for an hour, but couldn't find where OS-specific keybindings are defined. I'm probably not the right person to champion a patch, in hindsight.

They're at https://searchfox.org/mozilla-central/rev/557a0e222dd104c5d805ba344c45d6abc27d3db0/browser/base/content/browser-sets.inc#258-262 , with the localized shortcuts defined at https://searchfox.org/mozilla-central/rev/557a0e222dd104c5d805ba344c45d6abc27d3db0/browser/locales/en-US/browser/browserSets.ftl#134-147 . If you're changing them, note that you'll want to change the string identifiers too (not just the values).

I didn't realize that Chrome uses ctrl-shift-o for the library / bookmarks manager. It looks like it's accel-opt-b on mac, but ctrl-shift-o elsewhere. If we're aligning with that we should do the same here.

I was searching where the Ctrl-Shift-B vs Ctrl-Shift-O bindings were defined and was going to propose we unify them as Ctrl-Shift-O, as some have proposed in this discussion thread. This would make room for Ctrl-Shift-B to allow the booksmark toolbar to be shown/hidden.

Having a UX person weight in sounds like a good idea, though no doubt this behavior was already approved by the Chrome team's UX people long ago.

Aaron, can you rubberstamp us moving the library shortcut and adding one for the bookmarks toolbar to align with Chrome?

If we're doing this, it'd be worth (either here or in a follow-up) moving focus directly to (the first item in) the bookmarks toolbar if it's shown with the shortcut, so you can easily activate a bookmark with the keyboard.

Comment 38

[Marco Bonardo [:mak]]

The problem of being able to see the bookmarks toolbar only under certain circumstances has been reported multiple times, for example we have Bug 727668 that suggests a subset of users would like to see it only on "empty" pages or even have an alternative access point, but it's likely there's also users who prefer to always see it.
A keyboard shortcut may help a bit, but it's not very discoverable, and should activate keyboard navigation through bookmarks, otherwise you show the toolbar with the keyboard and then can't move through them?
A toggle button that one could customize into the toolbar may also do for mouse users (though we already have a contextual menuitem)

I think we must evaluate the general problem of "Seeing the toolbar only when it's useful" and pick a direction, if we can identify a usage pattern it would be better to do it in some automated fashion, if we go the shortcut path we should ensure keyboard navigation works.

Chrome's solution is also bit puzzling, it's not discoverable, the shortcut doesn't work on the new tab page and that's surprising.
I'm also not sold on using ctrl+shift+B to go to the toolbar, because while coherent with Chrome, it would break most Firefox users that use it to go the Library.
As suggested, this is a UX problem to unwrap from scratch.

Comment 39

[Marco Bonardo [:mak]]

Note that based on https://developer.gnome.org/hig/stable/keyboard-input.html.en
"In addition, the shortcuts for Unicode character entry should also be avoided. This includes Shift+Ctrl+A through to Shift+Ctrl+F, or Shift+Ctrl+0 through to Shift+Ctrl+9."
That is the reason CTRL+SHIFT+B was not used on Linux.

Comment 41

[Asif Youssuff]

Saw this post: https://www.reddit.com/r/firefox/comments/g5bz9k/my_mind_is_tellin_me_firefoxbut_my_bodymy_bodys/ where this bug is featured.

I just did a quick audit of the shortcuts for the bookmarks sidebar in other browsers.

In Safari, it is ⌘-⌃-1 (command-control-1)
In old Edge it is Ctrl-i
In Internet Explorer, it is ctrl-shift-i

The ctrl-shift-b shortcut works in old Edge and Internet Explorer, while command-shift-b works in Safari.

Safari, Chromium and New Edge (on macOS) use ⌘-⌥-b to open its bookmarks editor.
Chromium on Windows and Linux, New Edge (Windows) use control-shift-o to open their bookmarks editor

I don't think that all of these shortcuts are the greatest, but they do provide a path forward -- Firefox could use:

• for the bookmarks sidebar: ctrl-shift-i or ⌘-⌃-1 on Windows/Linux or macOS respectively (Ctrl-i is already used by Firefox's Page Info panel, which makes a lot of sense, imo).
• for the bookmarks editor control-shift-o on Windows and Linux. ⌘-⌥-b on macOS.
• for the bookmarks toolbar: ⌘-⇧-b/control-shift-b on macOS and Windows/Linux respectively.

There would be some jiggling around, but as a Linux user, I would only see one change (since Linux already uses the control-shift-o shortcut), and you also get to get rid of a collision with bold in text fields in rich forms.

Comment 42

[Marco Bonardo [:mak]]

I'm sorry but I don't understand the see-also bug you added, it's totally unrelated.

You also didn't address the fact ctrl+shift+b cannot be used on Linux.

Comment 43

[Asif Youssuff]

(In reply to Marco Bonardo [:mak] from comment #42)

I'm sorry but I don't understand the see-also bug you added, it's totally unrelated.

You also didn't address the fact ctrl+shift+b cannot be used on Linux.

That is actually the reason it is see also - platform rules can be broken in favor of consistency with other applications on the OS itself or Firefox itself on other OSes.

ctrl+shift+b is used in Linux Chromium, so this may be a situation where breaking the platform rules (like bug 1621570) is worthwhile.

Comment 44

[Dan Dascalescu]

Ctrl+Shift+B would be fantastic.

Comment 45

[Micah [:mtigley] (she/her)]

Attachment: Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r?jaws

Comment 46

[Pascal Chevrel:pascalc]

Tracking for 83 as it is likely to land in this cycle.

Comment 47

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94b3b8f32af5
Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,fluent-reviewers

Comment 48

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/94b3b8f32af5

Comment 49

[Sebastian Scarano]

'm sorry, I'm a bit lost with this countless updates
I see that is has been marked closed on 2020-09-30 and ths status is resolved

In which version will it be available? and what will be the keyboard shortcut in linux?

Thanks a lot

Comment 50

[Sebastian Scarano]

Sorry, I just saw that the target version is 83, thanks

Comment 51

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Sebastian Scarano from comment #50)

Sorry, I just saw that the target version is 83, thanks

This will likely stay on Nightly and early beta until Firefox 84.

Comment 52

[Micah [:mtigley] (she/her)]

(In reply to Sebastian Scarano from comment #49)

what will be the keyboard shortcut in linux?

The shortcut will be Ctrl+Shift+B on Linux and Windows. And Cmd+Shift+B on macOS.

Comment 53

[Sebastian Scarano]

That will be perfect, thanks a lot

Comment 54

[Micah [:mtigley] (she/her)]

Attachment: Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"

This reverts commit 2e95085964fa051c00039010e09839d3ae5cf359.

Comment 55

[Micah [:mtigley] (she/her)]

Comment on attachment 9186107 [details]
Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"

Beta/Release Uplift Approval Request

• User impact if declined: Users will see that the shortcut shown for opening the bookmarks library in the "Bookmarks" > "Show All Bookmarks" menu will always show "Ctrl+Shift+O" even if the new bookmarks pref is off.

This is confusing since we don't want users to see differing shortcuts for opening the bookmarks library between different releases.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ensure that "browser.toolbars.bookmarks.2h2020" is false

2. Press Ctrl+Shift+B to open the bookmarks library window.
3. Open menu "Bookmarks" > "Show All Bookmarks". Observe displayed shortcut.

ER:
The shortcut should be "Ctrl+Shift+B"

AR:
The shortcut displayed is "Ctrl+Shift+O"

Note: When the pref is enabled, the shortcut for opening the bookmarks library IS "Ctrl+Shift+O".

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Backing out a small change that allowed toggling the bookmarks toolbar via Ctrl+Shift+B
• String changes made/needed: reverting new string "bookmark-show-all-shortcut" in this backout

Comment 56

[Alin Ilea, Desktop Test Engineering]

Hi,
In my attempt to verify this in latest Nightly build 84.0a1 (2020-11-05) and Beta 83.0b9, using Windows 10, I observed the following behavior:
When browser.toolbars.bookmarks.2h2020 pref is set to true, ctrl+shit+B enables the bookmarks toolbar and the shortcut displayed near the Show All Bookmarks is Ctrl+Shit+O.
When browser.toolbars.bookmarks.2h2020 is set to false, indeed Ctrl+Shift+B open the bookmark library, but in the bookmarks menu still Ctrl+Shift+O is displayed near the Show All Bookmarks. Shouldn't be Ctrl+Shift+B displayed when the pref is set to false and the bookmarks library can be opened with Ctrl+Shift+B?
Thanks.

Comment 57

[:Gijs (he/him)]

(In reply to Alin Ilea from comment #56)

When browser.toolbars.bookmarks.2h2020 is set to false, indeed Ctrl+Shift+B open the bookmark library, but in the bookmarks menu still Ctrl+Shift+O is displayed near the Show All Bookmarks. Shouldn't be Ctrl+Shift+B displayed when the pref is set to false and the bookmarks library can be opened with Ctrl+Shift+B?

This is covered in bug 1672730, which is why there's a request to back this out of 83 beta, and in bug 1675549 for nightly.

Comment 58

[Pascal Chevrel:pascalc]

Comment on attachment 9186107 [details]
Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"

Approved for the beta branch before the merge, thanks.

Comment 59

[Alin Ilea, Desktop Test Engineering]

Given the fact that in 83.0 (build id: 20201110140026) the behavior is the same as in comment 56 but the shortcut displayed issue is covered by the bugs from comment 57, could this be marked as verified?
Thank you.

Comment 60

[Pascal Chevrel:pascalc]

Comment on attachment 9186107 [details]
Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"

We missed uplifting the backout as it was requested in the same bug as the landing so 83 was already marked as fixed, let's approve it for mozilla-release in case we have a RC2 as a ride-along if we have a driver (or a dot release).

Comment 61

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 62

[Ryan VanderMeulen [:RyanVM]]

Reverted for Fx83 RC2. This still remains landed for 84+.
https://hg.mozilla.org/releases/mozilla-release/rev/b4d233ef14ae

Comment 63

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9186107 [details]
Revert "Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,Gijs"

Clearing the approval to get this off the needs-uplift radar.

Comment 64

[Ryan VanderMeulen [:RyanVM]]

Follow-up fix to resolve test_Chrome_bookmarks.js failures:
https://hg.mozilla.org/releases/mozilla-release/rev/55359edc5d1cb8addecf9d2e7151782da543f67b

Comment 65

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in 83.0 (build id: 20201112153044). The Ctrl+Shift+B open the bookmark library and in the bookmarks menu Ctrl+Shift+B is displayed near the Show All Bookmarks. In latest Nightly 84.0a1 (build id: 20201112212842) Ctrl+Shift+B shortcut show/hide the bookmarks toolbar and the "Show all Bookmarks" shortcut displayed is Ctrl+shift+O. This behavior is the same with browser.toolbars.bookmarks.2h2020 pref set to false or true.

Comment 66

[Ryan Stokes]

How does this show/hide the bookmarks toolbar, as very simply stated, where in fact it opens the Library dialog? I'm a confused user.

Comment 67

[Ryan Stokes]

(In reply to Ryan Stokes from comment #66)

How does this show/hide the bookmarks toolbar, as very simply stated, where in fact it opens the Library dialog? I'm a confused user.

My mistake. Saw "Fixed in 83.0", but that was re: the bookmark library. Will be welcome. Thanks!

Comment 68

[Vam]

PRIVACY
For me, this is a strictly a privacy issue. I work for a fortune 500 company that requires a lot of video conferencing, live streaming my browser, screenshots, powerpoints and my Bookmarks Toolbar contains sensitive corporate information pertaining to supplychain, competition and cybersecurity that's not appropriate for the world to see.

SCREEN REAL ESTATE.
Almost EVERYONE can benefit from being able to quickly show/hide the bookmarks toolbar and screen real estate is also important. At times, I wish I could hide the bookmarks, the open tabs and only see the address bar. There's a reason from having more screen real estate

EVERY BROWSER HAS IT.
It works in Safari, Chrome, Brave, Edge and even IE9... INTERNET EXPLORER HAS IT, IT'S THE INDUSTRY STANDARD!
For every 1 person that posts here, there's another 5,000 that didn't take the time to register and another 10,000 that didn't even find this site. AND WHY WOULD THEY REGISTER, when it's clear that their request will ultimately be denied? All the "Comment hidden (offtopic)" posts are quite intimidating- I almost didn't post this.

EVERYBODY WANTS IT.
If I had to estimate, there's probably 5M people that want this and another 50M people that will want it when they realize what they're missing out on. When mom walks in the room, you might not want her seeing your "XXX LIVE NUDE POKEMON!" bookmarks. Let's be reasonable. FireFox is TWENTY YEARS OLD, people have been asking for this for ages, there's thousands of posts on Reddit, Mozillazine... Even SuperUser has 606 pages related to trying to modify the code themselves. It's mind-blowing how far you can customize FireFox for this to not be a thing... It's just not logical to not have this shortcut.

Comment 69

[Mark Banner (:standard8)]

Vam, this bug is already fixed - you can see the status as VERIFIED FIXED in the tracking section above. This fix is being rolled out currently, and should be released to everyone in Firefox 85 next Tuesday.

Bugzilla is a forum for developers to do work and we do hide comments that are not constructive or that do not add new/useful information... as otherwise the bugs can become difficult to read and follow the discussion that is actually relevant to fixing the bug. We also have a policy of no obligation, and your comment touches on both of these. Please read the etiquette before posting again.

Comment 70

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #69)

Vam, this bug is already fixed - you can see the status as VERIFIED FIXED in the tracking section above. This fix is being rolled out currently, and should be released to everyone in Firefox 85 next Tuesday

It's better than that, this has been fixed since the beginning of the 84 release, no roll-out -- the shortcut change was changed to not honour the roll-out preference in bug 1675549, because of the unpredictability it caused on beta.

Comment 71

[titule]

This was not a bug in the first place.
It is confusing for longtime users who can't find the Bookmark Manager function now, especially since the help have not been adjusted and all help pages on the net and on mozilla.org still list the old shortcut.
Very annoying that effort was wasted on this, which leads to a lot of frustration and displeasure among users. Don't you have any real bugs to fix?

Comment 72

[Kevin Ernst]

I have updated one of the longest-standing posts that I'm aware of on Stack Exchange about this issue—which I became aware of after the Hide BookmarksBar extension stopped working a number of years ago—to note that this has been resolved.

I get that changing an existing shortcut key on one platform is going to upset some people, but given all the others who were willing to go to with AutoHotkey, wmctrl, xdotool, and other hacks to get a shortcut for this, this will be a welcome change. (On macOS, you could have added a shortcut in the "Keyboard" prefpane in System Preferences, but even that was somewhat flaky).

My recommendation for those upset by the change would be to think of Shift+<modifer>+O as a mnemonic for "Organizer" instead of "Library," since that interface does more than just organize bookmarks now. The function of Shift+<modifier>+O (browse for and open something from the list of downloads, visited sites, and bookmarks) now harmonizes nicely with the File → Open File… function (<modifier>+O) as well (browse for and open something from the filesystem).

Thanks for your hard work, everyone. It seems like a minor issue, but as someone who regularly switches between all three OSes (and back and forth between Firefox and Chrome), often on a small laptop screen where real estate is at a premium, this increases my enjoyment of using Firefox quite a lot.