1673387 - Stop using texture arrays in the texture cache

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

We have run into a number of driver bugs with texture arrays, especially on android. avoiding texture arrays will let us remove some slow paths and workarounds. In addition, in order to implement more advanced texture atlas packing strategies, it is better to allow larger regions than 512x512.

Texture arrays originally allowed us to have a simple resizable storage with 512x512 granularity (each layer), but we stopped resizing texture arrays because of performance issues on windows+intel, so their only advantage now for the texture cache is size granularity which we don't take advantage of either.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1673387 - Don't use texture arrays for shared and standalone texture cache entries. r=gw

The patch ended up more complicated than I anticipated due to a lot of places in webrender assuming texture arrays unless specified otherwise.
The patch also merges TextureTarget into ImageBufferKind, and removes the realloc code path ing the texture cache (which is supposed to be dead code since because of performance issues on windows+intel).

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1673387 - Adjust reftest references. r=gw

Changing the size or number of layers of textures unfortunately usually leads to small sampling differences which requires fixing in the refetest references.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4cf743d6916
Don't use texture arrays for shared and standalone texture cache entries. r=gw
https://hg.mozilla.org/integration/autoland/rev/a755e87bf875
Adjust reftest references. r=jnicol

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for wrench/reftests/ failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/230fc37a1857517313297b2c1fa1d9b311406390
Log link: https://treeherder.mozilla.org/logviewer?job_id=320851835&repo=autoland&lineNumber=1468

Comment 6

[Narcis Beleuzu [:NarcisB]]

Please also take a look at this perma reftest failure:
https://treeherder.mozilla.org/logviewer?job_id=320862794&repo=autoland&lineNumber=4894

https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=fzoYwvFkRG6zovrASbZ0KQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Crunnable&fromchange=966c3db6690231ebe631dd20925c59d0fe185026&searchStr=android%2C8.0%2Cpixel2%2Caarch64%2Cwebrender%2Copt%2Creftests%2Ctest-android-hw-p2-8-0-android-aarch64-qr%2Fopt-geckoview-reftest-qr-e10s%2Cr1&tochange=e444f22bea93b592f06bfa9d9a0beef89e97414b

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1673387 - Don't use texture arrays for shared and standalone texture cache entries. r=gw

The patch ended up more complicated than I anticipated due to a lot of places in webrender assuming texture arrays unless specified otherwise.
The patch also merges TextureTarget into ImageBufferKind, and removes the realloc code path ing the texture cache (which is supposed to be dead code since because of performance issues on windows+intel).

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 1673387 - Adjust reftest references. r=gw

Changing the size or number of layers of textures unfortunately usually leads to small sampling differences which requires fixing in the refetest references.

Depends on D96816

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/591c4143921f
Don't use texture arrays for shared and standalone texture cache entries. r=gw
https://hg.mozilla.org/integration/autoland/rev/a315ba98577f
Adjust reftest references. r=jnicol

Comment 10

[Atila Butkovits]

Backed out for bustage on gradient_cache_hardstop_clip.yaml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/066dcb29ed85f8e7edee6afed408fecda1513c19

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=android%2C8.0%2Cpixel2%2Cdebug%2Cwebrender%2Cstandalone%2Cwebrender-android-hw-p2-debug%2Cwrench&revision=a315ba98577fd7d78de7ab380fc140e6783d2437&selectedTaskRun=OpyDmr3tRIO7RYbulUPk6A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321564627&repo=autoland&lineNumber=1593

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4edddc545827
Don't use texture arrays for shared and standalone texture cache entries. r=gw
https://hg.mozilla.org/integration/autoland/rev/4e6e7829d164
Adjust reftest references. r=jnicol

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4edddc545827
https://hg.mozilla.org/mozilla-central/rev/4e6e7829d164

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta for 84.0b4 for causing bug 1677696. It remains landed for 85+.
https://hg.mozilla.org/releases/mozilla-beta/rev/5ebdc746f3e8