1677696 - [Win7] Minimize, Maximize and Close buttons are no longer visible if Firefox Alpenglow theme is used with Webrender

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: alpenglow_00.gif

Affected versions

• 84.0b1 (20201116212331)
• 85.0a1(20201116210217)

Affected platforms

• Windows 7x64

Steps to reproduce

1. Open Firefox and go to Customize mode.
2. Set Alpenglow theme and observe the top buttons.

Expected result

• Buttons are displayed as expected.

Actual result

• The buttons are not displayed.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=762270e639cf76b91a06d99f4a0639e2b6192af3&tochange=4e6e7829d164521667c5df5b67ef0bbcabb139a0

Notes

• Attached a screen recording.
• I cannot reproduce the issue on Windows 10x64, macOS 10.12, or Ubuntu 18.04.
• The issue is not reproducible with WebRender disabled.

Suggested Severity: S3

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Nicolas Silva, it seems that the patches from bug 1673387 caused the regression. Can you please have a look? Thank you!

Comment 2

[do.not.know.me]

Hi, sorry to intrude.
I have a similar problem on Win7x64 after installing 83.0, except instead of Alpenglow it's Dark theme.
If I restart Firefox in safe mode, everything is fine, but if I disable all my add-ons manually and then restart, the problem reappears.
gfx.webrender.all is set to false (by default, I suppose, never heard of it before).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Hi Jim, with WR rolling out to Win7 in 83, this seems like a scary regression. Can you please help prioritize?

Comment 4

[Jim Mathies [:jimm]]

Nical is going through his needinfos today so he should get to this soon.

Comment 5

[Nicolas Silva [:nical]]

I might have broken the clear primitive which is only used on win7 to draw the window buttons. I'm still investigating and with the wellness days coming I think that it would be safer to back out bug 1673387 from beta (but leave it in nightly).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout for 84.0b4.
https://hg.mozilla.org/releases/mozilla-beta/rev/5ebdc746f3e8

Comment 8

[Cletus Van Damme]

I can reproduce this on Windows 8.1 x64, using Nightly 85.0a1 20201121213746 with a fresh profile and following the reporter's steps. Initially encountered the problem with 84 betas when using a third-party add-on theme. Could not reproduce on 83.

Comment 9

[Cletus Van Damme]

Haven't encountered this issue on 84 since the update to 84.0b4.

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1677696 - Use texture array shader variant for clear tiles. r=gw

The dummy texture is a texture array. The bug was caused by selecting the non-array version of the shader while binding a texture array.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ae1b44e7a6
Use texture array shader variant for clear tiles. r=jnicol

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d7ae1b44e7a6

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

The issue is verified fixed with Firefox 85.0a1 (20201208213457) and 84.0 (20201207203640) on Windows 7x64. The buttons are correctly displayed while using the Alpenglow theme or another non-default theme.