1673586 - Print Previewing Screenshots renders inconsistencies accross platforms while saving to PDF or Printer Destination

Status: RESOLVED WORKSFORME

(Firefox :: Screenshots, defect, P3)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Print Screenshot Selection.gif

Affected versions

• 83.0b4
• 84.0a1

Affected platforms

• Windows 10x64
• macOS 10.15.7
• Ubuntu 20.04

Steps to reproduce

1. Launch FF.
2. Go to any random website(eg: wikipedia.com)
3. Right click the page and select Screenshot
4. Drag the margin of the Screenshot UI and select an area.
5. CTRL+P
6. Select Print to PDF.

Expected result

• Only the selected screenshot area should be displayed inside the print preview.

Actual results

• Save to PDF mode:
• On macOS , the selected area is displayed as the first page, and the rest of the document follows in the next pages in full.
• on Ubuntu the same behavior as above is applied.
• On Windows, the whole page is displayed, with the shadow effect and UI of the Screenshot tool and the entirety of the document, disregarding the selection entirely

*Printer destination:

• On macOS, the whole page is displayed, with the shadow effect and UI of the Screenshot tool and the entirety of the document, disregarding the selection entirely
• On Ubuntu the same behavior as above is applied
• On Windows, the whole page is displayed, with the with the shadow effect and UI of the Screenshot tool , but only the selection page is displayed

Suggested Severity

• Seeing as how this occurs on all platforms, and it does concern a functionality that is easy to use by the user without any workarounds, I would S2 this issue.

Regression range

• Will return with regression ASAP.

Additional notes

• I would consider that the correct behavior would be that only the selected range to be displayed inside the print preview, without the rest of the document of the page for both Save to PDF or Printer destination.
• This issue occurs on the old modal as well.
• Screen cast of the issue:
  https://drive.google.com/file/d/1URtHJIp6eZ7L4pSRVO2aqLtkH04APhUj/view?usp=sharing

Comment 1

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

I have been searching for a regression and have reached Fx54 with the same repro steps . This issue does not seem like a regression

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Only the selected screenshot area should be displayed inside the print preview.

Not sure that'd be my expectation fwiw. It sure is a bit weird to print the modal, but that's the state of the page right now. If we want to fix this this probably needs integration from the screenshots code somehow... But honestly I don't think this is an S2.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emalysz, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Sam Foster [:sfoster] (he/him)]

In the new implementation (set screenshots.browser.component.enabled to true), with the same STR the screenshots UI is removed entirely in the print preview. I think that's what I'd expect? That being the case, I'll block this on our meta bug for that work.

Comment 6

[Simona Badau, Desktop QA]

Attachment: Screenshot.png

(In reply to Sam Foster [:sfoster] out until 2024-01-02 (he/him) from comment #5)

In the new implementation (set screenshots.browser.component.enabled to true), with the same STR the screenshots UI is removed entirely in the print preview. I think that's what I'd expect? That being the case, I'll block this on our meta bug for that work.

Tested this scenario on the latest Nightly 123.0a1 having the preference 'screenshots.browser.component.enabled' set to 'true', and the screenshots UI is still not removed when doing a print preview. Additionally I've observed an overlapping of buttons ("Save visible" and "Save full page") over the print modal.

Comment 7

[Sam Foster [:sfoster] (he/him)]

This is fixed with the pref-flip in bug 1870127 that makes the new component implementation the default - the screenshots overlay is hidden as expected in the print preview.