1673861 - Footer buttons in panelpopups have a border radius

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

In panelpopups the big buttons on bottom, like the Add-on installation confirmation or the edit contact panel opened through the address star in the message header, have on Linux and better visible on Mac a border radius. They should have none. On Windows 10 this isn't visible as we have a button border radius of 0px.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1673861-no-border-radius-panel-buttons.patch

This is probably a regression of bug 1650789.

When I was on it, I simplified the editContactPanel styles by using the toolkit classes instead of our own. I also moved the shared code to a shared file.

For the issue with the border-radius is only the change in messenger.css needed.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9184247 [details] [diff] [review]
1673861-no-border-radius-panel-buttons.patch

Review of attachment 9184247 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
I noticed that now the `Done` button when viewing the contact popup is way larger than the other 2 buttons.
Is this on purpose?
Could it be fixed so the 3 buttons expand to uniformly fill the available space?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1673861-no-border-radius-panel-buttons.patch

Reverted the flex rule that the popup-notification-primary-button class uses in editContactPanel.css to make them the same width.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/275c4b654b7e
Remove the border-radius of the panel's bottom buttons. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9184368 [details] [diff] [review]
1673861-no-border-radius-panel-buttons.patch

[Approval Request Comment]
Regression caused by (bug #): 1650789
User impact if declined: weird appearance of the footer buttons in panelpopups
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1673861-no-border-radius-panel-buttons-ESR.patch

[Approval Request Comment]
Regression caused by (bug #): 1650789
User impact if declined: weird appearance of the footer buttons in panelpopups
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9184368 [details] [diff] [review]
1673861-no-border-radius-panel-buttons.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1fa2d48e6347

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9184507 [details] [diff] [review]
1673861-no-border-radius-panel-buttons-ESR.patch

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/49e848fab21c