1674000 - Use better colors for the search mode indicator in Windows high-contrast mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

Currently the search indicator uses the default/light colors in Windows high-contrast mode. They look out of place, and as Tim suggests, we should use system colors anyway:

High-contrast mode can also be completely light with black borders on Windows, not sure that would fit well in this case. Best choice for HC-mode would be using system colors (Highlight + HighlightText maybe?).

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1674000 - Use better colors for the search mode indicator in Windows high-contrast themes.

Here's what this looks like in all of Windows 10's high-contrast themes. I tried keeping the border the same color as the text but I don't think it looked good, so I made it the same color as the background.

{F2546521}

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7f1f7237720
Use better colors for the search mode indicator in Windows high-contrast themes. r=ntim

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e7f1f7237720

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1674000 - Apply changes from bug 1674031. DONTBUILD

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a5b07f82228
Apply changes from bug 1674031. DONTBUILD

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a5b07f82228

Comment 7

[Drew Willcoxon :adw]

Attachment: Beta patch

Approval Request Comment
[Feature/Bug causing the regression]:
Quantumbar update2, search mode

[User impact if declined]:
The new search mode indicator looks pretty bad in Windows high-contrast themes. This patch improves its appearance.

[Is this code covered by automated tests?]:
No, this is a CSS-only change.

[Needs manual test from QE? If yes, steps to reproduce]:
Yes, enter search mode in a high-contrast theme on Windows. This is the expected appearance for each of the four high-contrast themes on Windows 10: https://d3kxowhw4s8amj.cloudfront.net/file/data/oclsbldzqshuf3rojw7n/PHID-FILE-gmxisup4rbv5d3p6fquk/high-contrast-1674000.png

[Is the change risky?]:
No, low risk

[Why is the change risky/not risky?]:
This is a CSS-only change.

I'm posting a new patch for beta instead of requesting uplift on the Phabricator revision because bug 1674031 landed in between bug 1671668, which was uplifted, and this bug, so the Phabricator revision doesn't apply cleanly to beta due to a one-line conflict. Bug 1674031 is cleanup and therefore doesn't need to be uplifted, but it also wouldn't hurt if anyone preferred to do that instead.

I've verified this patch on beta on Windows and Mac.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9184702 [details] [diff] [review]
Beta patch

approved for 83.0b7

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/78ed61534c35

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using latest Nightly 84.0a1 2020-10-29 under Win 10 64-bit.
Leaving the flags until 83 Beta 7 build will be available for verification.

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 83 beta 7, Win 10 x64.