1683206 - Intermittent TV browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Uncaught exception - Other Bookmarks folder failed to show in other window. - threw exception: TypeError: can't access property "hidden", otherBookmarks is null

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=324858234&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/B41YnjsgQ1W-O5ONUdgYgQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/B41YnjsgQ1W-O5ONUdgYgQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

...
[task 2020-12-17T20:54:36.447Z] 20:54:36     INFO - Entering test bound testShowingOtherBookmarksContextMenuItem
[task 2020-12-17T20:54:36.447Z] 20:54:36     INFO - Add bookmark to Other Bookmarks.
[task 2020-12-17T20:54:36.447Z] 20:54:36     INFO - 'Show Other Bookmarks' menu item should be checked by default.
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - Check 'Show Other Bookmarks' menu item state
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Other Bookmarks item's checked state should be true - 
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - Toggle off showing the Other Bookmarks folder.
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - Select 'Show Other Bookmarks' menu item
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - Buffered messages logged at 20:54:34
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - Check 'Show Other Bookmarks' menu item state
[task 2020-12-17T20:54:36.448Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Other Bookmarks item's checked state should be false - 
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - Test whether or not the 'Other Bookmarks' folder is visible.
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Other Bookmarks folder "hidden" state should be true. - 
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - Toggle on showing the Other Bookmarks folder.
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - Select 'Show Other Bookmarks' menu item
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - Check 'Show Other Bookmarks' menu item state
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Other Bookmarks item's checked state should be true - 
[task 2020-12-17T20:54:36.449Z] 20:54:36     INFO - Test whether or not the 'Other Bookmarks' folder is visible.
[task 2020-12-17T20:54:36.450Z] 20:54:36     INFO - Buffered messages logged at 20:54:35
[task 2020-12-17T20:54:36.450Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Other Bookmarks folder "hidden" state should be false. - 
[task 2020-12-17T20:54:36.450Z] 20:54:36     INFO - Ensure 'Show Other Bookmarks' isn't shown when Other Bookmarks is empty.
[task 2020-12-17T20:54:36.455Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | 'Show Other Bookmarks' menu item appearance state is correct. - 
[task 2020-12-17T20:54:36.455Z] 20:54:36     INFO - Add a bookmark to the empty Other Bookmarks folder.
[task 2020-12-17T20:54:36.455Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | 'Show Other Bookmarks' menu item appearance state is correct. - 
[task 2020-12-17T20:54:36.455Z] 20:54:36     INFO - Ensure that displaying Other Bookmarks is consistent across separate windows.
[task 2020-12-17T20:54:36.455Z] 20:54:36     INFO - Buffered messages finished
[task 2020-12-17T20:54:36.456Z] 20:54:36     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Uncaught exception - Other Bookmarks folder failed to show in other window. - threw exception: TypeError: can't access property "hidden", otherBookmarks is null
[task 2020-12-17T20:54:36.456Z] 20:54:36     INFO - Leaving test bound testShowingOtherBookmarksContextMenuItem
[task 2020-12-17T20:54:36.456Z] 20:54:36     INFO - Entering test bound showOtherBookmarksMenuItemPrefDisabled
[task 2020-12-17T20:54:36.456Z] 20:54:36     INFO - GECKO(1313) | [Parent 1313: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 33 (0x11158f000) [pid = 1313] [serial = 38] [outer = 0x0] [url = about:blank]
[task 2020-12-17T20:54:36.456Z] 20:54:36     INFO - GECKO(1313) | [Parent 1313: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 32 (0x128d67c00) [pid = 1313] [serial = 34] [outer = 0x0] [url = about:blank]
[task 2020-12-17T20:54:36.529Z] 20:54:36     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | 'Show Other Bookmarks' menu item appearance state is correct. - ```

Comment 1

[:Gijs (he/him)]

This appears to be because https://hg.mozilla.org/integration/autoland/file/2eb02d6cba444cca709cedf06a3dd191407ab76f/browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js#l319 does not cope with the item being removed (rather than just hidden) in the other window.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1683206 - fix browser_toolbar_other_bookmarks.js accessing a removed otherBookmarks element, r?mtigley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1860e73acc8
fix browser_toolbar_other_bookmarks.js accessing a removed otherBookmarks element, r=mtigley

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f1860e73acc8

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1674840

Comment 6

[Intermittent Failures Robot]

4 failures in 3421 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 1

Platform breakdown:

• macosx1014-64-qr: 3
• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1683206&startday=2020-12-14&endday=2020-12-20&tree=all