1675248 - Remove usage of Marionette:ListenersAttached from openTab() method

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The method openTab() in browser.js makes use of a framescript event:
https://searchfox.org/mozilla-central/rev/e75e8e5b980ef18f4596a783fbc8a36621de7d1e/testing/marionette/browser.js#398-414

To stop running the framescript when actors are enabled (bug 1669174) we have to get rid of this code, and find a proper replacement.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7).

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Here a try build that has this code removed:
https://treeherder.mozilla.org/jobs?repo=try&revision=dd0f52f771b18b5f248a20b9c3d771dafcce09fb

Lets see if that works in both the framescript and actor case. I would assume so given that the driver still waits for the content browser to be created.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1675248 - [marionette] Don't wait for Marionette:ListenersAttached in openTab().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/231b1e4bac1b
[marionette] Don't wait for Marionette:ListenersAttached in openTab(). r=marionette-reviewers,maja_zf

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/231b1e4bac1b

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for WD failure on new_tab.py
The push turned Bug 1674207 into a perma fail

Backout link: https://hg.mozilla.org/integration/autoland/rev/13131742857db276986af599c269131c74f09f30
Log link: https://treeherder.mozilla.org/logviewer?job_id=321046937&repo=autoland&lineNumber=3301
Retriggs: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Crunnable&fromchange=bdd3d7eb59276188d6dee4f542c8f0e772b5ddef&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-wdspec-fis-e10s%2Cwd1&tochange=8822ff7914a670de3a104fa997be7f64fe25941d&selectedTaskRun=T2IbWRC1S3mH0NOC1s9O1g.0

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/13131742857d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20022a056e94
[marionette] Don't wait for Marionette:ListenersAttached in openTab(). r=marionette-reviewers,maja_zf

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/20022a056e94