1675676 - Allow specifying a different ServerURL in application.ini.in

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Edmund Wong (:ewong)]

Socorro is phasing out support for ingesting crash reports from SeaMonkey (Bug 1608976) and Thunderbird (bug 1604848).

Both products use application.ini.in's ServerURL's entry to specify where to send the crash stats as stated:

ServerURL=https://crash-reports.mozilla.com/submit?id=@MOZ_APP_ID@&version=@MOZ_APP_VERSION@&buildid=@MOZ_BUILDID@

Since crash-reports.mozilla.com is hard-coded, it would make migrating off this server hard.

I can see a few options though it's been a long time since i've touched the build config so I don't know the far-reaching affects of this change.

in confvars.sh:

MOZ_CRASHREPORTER_SERVER=https://<server>/<path>

in application.ini.in:
ServerURL=@MOZ_CRASHREPORTER_SERVER?id....

Or even have the whole URL defined in confvars.sh, i.e.

MOZ_CRASHREPORTER_URL=<full url including id, buildid, version>

in application.ini.in:
ServerURL=@MOZ_CRASHREPORTER_URL@

Comment 1

[Edmund Wong (:ewong)]

Attachment: wip:

a wip.. (had the intention to set the whole URL, but build_id isn't available during that point (* I think... could be wrong..*)

so in TB and/or SM, in confvafs.sh, one could specify MOZ_CRASHREPORTER_URL to point to the
correct url.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 9186187 [details] [diff] [review]
wip:

Review of attachment 9186187 [details] [diff] [review]:
-----------------------------------------------------------------

Please use phabricator https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch
The UI in bugzilla doesn't allow to write proper reviews anymore. I'm surprised you were able to set a review flag at all.

Please don't set the default crash reporter url in confvars.sh, because your change, for instance, excludes mobile/android. It would be better to have the default in configure. Also, please don't set this in old-configure. Use python configure. The ideal place for this would be toolkit/moz.configure.

Comment 3

[Magnus Melin [:mkmelin]]

See bug 1628329.

Comment 4

[Edmund Wong (:ewong)]

(In reply to Mike Hommey [:glandium] from comment #2)

Comment on attachment 9186187 [details] [diff] [review]
wip:

Review of attachment 9186187 [details] [diff] [review]:

Please use phabricator
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.
html#to-submit-a-patch
The UI in bugzilla doesn't allow to write proper reviews anymore. I'm
surprised you were able to set a review flag at all.

A bug?

Please don't set the default crash reporter url in confvars.sh, because your
change, for instance, excludes mobile/android. It would be better to have
the default in configure. Also, please don't set this in old-configure. Use
python configure. The ideal place for this would be toolkit/moz.configure.

Thanks for the info. I haven't submitted a patch to core in a long time,
so a learning experience.

Just to clarify, toolkit/moz.configure is the only place? I don't need to
fiddle with build/moz.build?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Edmund Wong (:ewong) from comment #4)

(In reply to Mike Hommey [:glandium] from comment #2)

Comment on attachment 9186187 [details] [diff] [review]
wip:

Review of attachment 9186187 [details] [diff] [review]:

Please use phabricator
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.
html#to-submit-a-patch
The UI in bugzilla doesn't allow to write proper reviews anymore. I'm
surprised you were able to set a review flag at all.

A bug?

A feature.

Please don't set the default crash reporter url in confvars.sh, because your
change, for instance, excludes mobile/android. It would be better to have
the default in configure. Also, please don't set this in old-configure. Use
python configure. The ideal place for this would be toolkit/moz.configure.

Thanks for the info. I haven't submitted a patch to core in a long time,
so a learning experience.

Just to clarify, toolkit/moz.configure is the only place? I don't need to
fiddle with build/moz.build?

You'll still have to, to pass the right things for application.ini

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Thanks for the info. I haven't submitted a patch to core in a long time,
so a learning experience.

This doc is up to date:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Comment 7

[Edmund Wong (:ewong)]

Attachment: Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r?glandium,gsvelto

Comment 8

[Edmund Wong (:ewong)]

Attachment: Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r?glandium

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ewong, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Edmund Wong (:ewong)]

@glandium, It's been a long time since I've pushed anything (can't push right now as my hg creds are still disabled). What needs to be done now?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bee2ef0fc0e7
Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r=glandium,gsvelto

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bfbb6e4c5dd
Lint fix. a=fix. CLOSED TREE

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bee2ef0fc0e7
https://hg.mozilla.org/mozilla-central/rev/2bfbb6e4c5dd

Comment 14

[Razvan Maries]

Backed out for sending crash reports to wrong host.

https://hg.mozilla.org/mozilla-central/rev/1c1dbf630893604844a607bfe87b73253267b01a

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

crash-stats.mozilla.com got used instead of crash-reports.mozilla.com and the host variable contains the trailing / while it is also part of the submission url variable.

Comment 16

[Edmund Wong (:ewong)]

(In reply to Razvan Maries from comment #14)

Backed out for sending crash reports to wrong host.

https://hg.mozilla.org/mozilla-central/rev/1c1dbf630893604844a607bfe87b73253267b01a

My apologies. Will get this fixed.

Comment 17

[Edmund Wong (:ewong)]

Attachment: Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-reporter server url. r?glandium,gsvelto

Depends on D96322

Comment 18

[Edmund Wong (:ewong)]

Attachment: Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r?glandium,gsvelto

Depends on D96498

Comment 19

[Magnus Melin [:mkmelin]]

ewong, had the chance to update the patch?

Comment 20

[Edmund Wong (:ewong)]

(In reply to Magnus Melin [:mkmelin] from comment #19)

ewong, had the chance to update the patch?

Yes, I have and I thought I had updated it. I'll take a look.

Comment 21

[Edmund Wong (:ewong)]

@glandium, I'm sorry for the delay in getting this bug done, but can you point out what other changes need to be done? I'm still not familiar with phabricator and I thought I had updated the patch. What else am I missing? Do I need a check-in needed? Thanks!

Comment 22

[Mike Hommey [:glandium]]

(In reply to Edmund Wong (:ewong) from comment #21)

Do I need a check-in needed?

Looks like it. Except if you have commit access level 3, in case you can land yourself.

Comment 23

[Edmund Wong (:ewong)]

(In reply to Mike Hommey [:glandium] from comment #22)

(In reply to Edmund Wong (:ewong) from comment #21)

Do I need a check-in needed?

Looks like it. Except if you have commit access level 3, in case you can land yourself.

Thanks for the help! It seems as if they've removed the checkin-needed (and I'm not sure if check-in needed-tb is what I should use).

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b535199dc605
Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r=glandium,gsvelto

Comment 25

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b535199dc605