Closed Bug 1628329 Opened 4 years ago Closed 3 years ago

Thunderbird crash-stats related endpoint changes

Categories

(Thunderbird :: General, task, P2)

Tracking

(thunderbird_esr78 wontfix, thunderbird90 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird90 --- fixed

People

(Reporter: mkmelin, Assigned: rjl)

References

Details

Attachments

(1 file)

See bug 1608971.

We should change the endpoints we point to to use the Thunderbird corresponding ones. There is

pref("breakpad.reportURL", "https://crash-stats.mozilla.com/report/index/");

pref("toolkit.crashreporter.infoURL",
"https://www.mozilla.org/thunderbird/legal/privacy/#crash-reporter");

And also ServerURL at https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/build/application.ini.in#50 (which can be overriden for testing with MOZ_CRASHREPORTER_URL)

I think application.ini.in should be changed to take a variable for the serverURL hostname.

Priority: -- → P2

How's this going to work from the Mozilla side?

I have CNAMED https://crash-stats.thunderbird.net and https://crash-reports.thunderbird.net over to the respective Mozilla domains, but of course that will not work unless they adjust their SSL certs for those domains.

The current crash-stats certificate expires 2021-02-17. I guess when renewing that would be a good time to add the thunderbird names.

Depends on: 1608971
Depends on: 1675676

Will, can the SSL certs be adjusted?

Flags: needinfo?(willkg)

Magnus: I'm not sure I understand what that means. Can you elaborate?

Flags: needinfo?(willkg) → needinfo?(mkmelin+mozilla)

Sure, the SSL certificates for crash-stats.mozilla.org (and crash-reports) are only valid for that hostname. So until the certificate is also valid for a Thunderbird related endpoint (comment 1) we could not switch clients over to the new endpoints.

Once we switch to something else we'd point the Thunderbird endpoints to what that is, but without adjusting the certificates that would have to happen "over night" for all clients which seems impossible. If the certificates are adjusted we can switch this client side already, then we just point the crash-stats.thunderbird.net domain elsewhere once we're ready.

Flags: needinfo?(mkmelin+mozilla) → needinfo?(willkg)

What domain name do you want to be added to the crash-stats.mozilla.org (the webapp) certificate?

What domain name do you want added to the crash-reports.mozilla.com (the crash ingestion pipeline collector) certificate?

Flags: needinfo?(willkg) → needinfo?(mkmelin+mozilla)

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #6)

What domain name do you want to be added to the crash-stats.mozilla.org (the webapp) certificate?

crash-stats.thunderbird.net

What domain name do you want added to the crash-reports.mozilla.com (the crash ingestion pipeline collector) certificate?

crash-reports.thunderbird.net

Flags: needinfo?(mkmelin+mozilla)

I talked to my ops person. It's really complicated and a lot of time and effort to add the domains you want added to our SSL certificates. Further, we reissued our certificates already.

Is it possible to do something like this?:

  1. For crash-stats (the webapp), I think you should set up a basic nginx server that takes incoming crash-stats.thunderbird.net urls and redirects them to crash-stats.mozilla.org.

  2. For crash-reports (the crash ingestion pipeline collector), I suggest you set up a tee server that takes an incoming HTTP POST, does the HTTP POST on behalf of the client to crash-reports.mozilla.com, gets back the response, and then sends the response to the client.

Flags: needinfo?(mkmelin+mozilla)

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #8)

Is it possible to do something like this?:

  1. For crash-stats (the webapp), I think you should set up a basic nginx server that takes incoming crash-stats.thunderbird.net urls and redirects them to crash-stats.mozilla.org.

Redirects are trivial so sure.

  1. For crash-reports (the crash ingestion pipeline collector), I suggest you set up a tee server that takes an incoming HTTP POST, does the HTTP POST on behalf of the client to crash-reports.mozilla.com, gets back the response, and then sends the response to the client.

Sorry but this suggestion seems unreasonable to me. You're saying that setting up a bandwidth/request intensive forwarding service that can't use caching is easier than changing an SSL cert? Something is seriously wrong if that's the case.

I know that Firefox/Thunderbird should be able to follow 307 redirects for POSTs, but I don't know if this applies to the crash reporter service...

For #1 it's easy.
For #2 we'll investigate if we can just HTTP 307 redirect it appropriately.

Flags: needinfo?(mkmelin+mozilla)

Sets an alternate crashreporter url used by the breakpad client and the
Javascript submitter.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Assignee: rob → nobody
Status: ASSIGNED → NEW
Assignee: nobody → rob
Status: NEW → ASSIGNED

Comment on attachment 9226903 [details]
Bug 1628329 - Set MOZ_CRASHREPORTER_URL at build time. r=sancus

[Approval Request Comment]
Risk to taking this patch (and alternatives if risky):
This changes the URL target for the crash reporter only, which is low risk as it doesn't affect any other client code.

Attachment #9226903 - Flags: approval-comm-beta?

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/d0f8efdda8e5
Set MOZ_CRASHREPORTER_URL at build time. r=sancus

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9226903 [details]
Bug 1628329 - Set MOZ_CRASHREPORTER_URL at build time. r=sancus

[Triage Comment]
Approved for beta

Attachment #9226903 - Flags: approval-comm-beta? → approval-comm-beta+
Target Milestone: --- → 91 Branch

Comment on attachment 9226903 [details]
Bug 1628329 - Set MOZ_CRASHREPORTER_URL at build time. r=sancus

[Approval Request Comment]

We should get this into the next ESR78 so that crash reports don't bounce when Socorro stops accepting Thunderbird reports.

Attachment #9226903 - Flags: approval-comm-esr78?

Comment on attachment 9226903 [details]
Bug 1628329 - Set MOZ_CRASHREPORTER_URL at build time. r=sancus

[Triage Comment]
Approved for esr78

Attachment #9226903 - Flags: approval-comm-esr78? → approval-comm-esr78+

Comment on attachment 9226903 [details]
Bug 1628329 - Set MOZ_CRASHREPORTER_URL at build time. r=sancus

Not possible with esr78

Attachment #9226903 - Flags: approval-comm-esr78+
No longer depends on: 1744121
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: