1676680 - Unify/simplify the dark theme selectors

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

At https://searchfox.org/comm-central/source/mail/themes/shared/mail/messenger.css#118-131 we many lines to select the elements. It's possible to simplify this selectors.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1676680-dark-theme-selector.patch

I'm now using the classes .full-themeable for elements that apply full- and LW-dark themes and .full-brighttext-themeable for elements that only apply to full themes (for example the messgeHeader). There are many files touched because of the class name changes.

In messengercompose.css I moved more to the shared file. And I moved quickFilterBar.css from content to the shared themes folder.

When you don't like the class names I can change them. But you need to propose new ones. ;-)

Comment 2

[Alessandro Castellani [:aleca]]

Nice, this is a great improvement and will help us keep our sanity when in need of themeing new elements.

What about updating the class names to .themeable-full and .themeable-brighttext? I think we should use the "static" part of the class name at the beginning, and then concatenate variations.

I know our current "approach" in naming CSS is the other way around, (eg ***-toolbar, or ***-button) but I think we should start using this other approach.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1676680-dark-theme-selector.patch

Same patch with updated class names.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9187187 [details] [diff] [review]
1676680-dark-theme-selector.patch

Review of attachment 9187187 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3b62c0153ff
Unify/simplify the dark theme selectors. r=aleca