1676705 - Wayland: Microphone indicator window gains focus and is centered on the screen (privacy.webrtc.legacyGlobalIndicator is still true for Linux beta&stable, otherwise false)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[hagen.echzell]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

The problem occurs for "click and hold"-scenatios, like when sending a voice message in Whatsapp Web.
Open Whatsapp web. Try sending a voice message by holding down the Microphone button (you might have to allow microphone access first).

My System: A current Fedora with Gnome on Wayland. Firefox 82.0.2
widget.wayland-dmabuf-vaapi.enabled set to true, if this is relevant

Actual results:

The Microphone/Camera indicator pops up as a new window. Focus from the original Window is lost, so is the keypress event, apparently, and the voice recording aborts immediately.

Expected results:

The main firefox window should have kept focus, while still showing the microphone indicator.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[alex_mayorga]

¡Hola Hagen!

Thanks for your bug report.

Does this bug still occur on the recently released Firefox 84[1]?
Does the bug occur in Beta, Developer and Nightly[2]?
Can you please confirm?

¡Gracias!
Alex

[1] https://www.mozilla.org/firefox/84.0/releasenotes/
[2] https://www.mozilla.org/firefox/channel/desktop/

Comment 3

[hagen.echzell]

Hi Alex,

the bug is reproducible on a current firefox 84.0
I'll need some time to check on beta, developer and nightly, since I only have my productive machine atm and don't want to mess with it.

Best
Hagen

Comment 4

[hagen.echzell]

I switched from Gnome to KDE Plasma over the holidays. So the only thing I can say is, under Plasma (wayland) and Firefox 84.0.1, the bug doesn't occur. Maybe someone can check with Gnome and a current Firefox again?

Comment 5

[Maxim Mikityanskiy]

I had to set MOZ_ENABLE_WAYLAND=1 to work around bug 1789602, and this bug started affecting me. Whenever I enter any conference call, the microphone indicator appears as a separate window, which means:

1. It's centered, instead of sticking to the top.
2. It gains focus, stealing focus from the main window.
3. It appears in Alt+Tab and Alt+backtick, making switching between Firefox windows (and windows in general) harder.
4. It can be closed with Alt+F4, and there is not way to bring it back.
5. It doesn't stay on top and gets covered by the Firefox window when I switch back to it.

All this causes huge usability issues for me. The alternative is to disable MOZ_ENABLE_WAYLAND and switch to Xwayland, but it's even worse because of bug 1789602.

Firefox 111.0.1, GNOME, Wayland, Arch Linux.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Does it help if you set privacy.webrtc.legacyGlobalIndicator to false at about:config and try the conference?
Thanks.

Comment 7

[Maxim Mikityanskiy]

Does it help if you set privacy.webrtc.legacyGlobalIndicator to false at about:config and try the conference?

If I set that, the indicator just doesn't appear at all.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Can you try latest nightly + privacy.webrtc.legacyGlobalIndicator change?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries
Thanks.

Comment 9

[Darkspirit]

Original bug is gone: WhatsApp and Telegram have changed their UI. One click and voice recording is active until a stop button is pressed.

(In reply to Maxim Mikityanskiy from comment #7)

Does it help if you set privacy.webrtc.legacyGlobalIndicator to false at about:config and try the conference?

If I set that, the indicator just doesn't appear at all.

That's how it should be. With privacy.webrtc.legacyGlobalIndicator=false, the indicator is only shown for screensharing.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:stransky, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit BugBot documentation.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Can you try latest nightly + privacy.webrtc.legacyGlobalIndicator change?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries
Thanks.

Comment 12

[Darkspirit]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #11)

Can you try latest nightly + privacy.webrtc.legacyGlobalIndicator change?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries
Thanks.

No, only one of them, otherwise it would bring the problem back.
Linux Beta+Stable have problematic privacy.webrtc.legacyGlobalIndicator=true.
Linux Nightly and Mac+Windows Nightly/Beta/Stable (bug 1665490) have privacy.webrtc.legacyGlobalIndicator=false (=no microphone indicator window).

• This bug should set privacy.webrtc.legacyGlobalIndicator to false for Linux Beta+Stable to get parity with Mac+Windows (=show small indicator window only for screensharing, not for microphone. Tab and address bar and Gnome+KDE already show a microphone indicator):
  Either remove https://searchfox.org/mozilla-central/rev/445a5ab684b73eb56d807d0f3b2fabcc85a7c3dd/browser/app/profile/firefox.js#2058
  or replace NIGHTLY_BUILD with MOZ_WIDGET_GTK.

  (bug 1639821: 6 Linux users have reported that setting privacy.webrtc.legacyGlobalIndicator to false solves that bug for Linux.
  Offtopic: 2 Windows users have reported that setting it to true solves it for Windows.)

• bug 1668358 should remove the screensharing indicator window for at least Gnome and KDE.

Comment 13

[Darkspirit]

This comment confirmed the fix:

(Maxim Mikityanskiy from comment #7)

Does it help if you set privacy.webrtc.legacyGlobalIndicator to false at about:config and try the conference?

If I set that, the indicator just doesn't appear at all.

Comment 15

[Darkspirit]

Attachment: Bug 1676705 - Enable the new WebRTC global indicator by default. r=mconley

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43f8f3725d2b
Enable the new WebRTC global indicator by default. r=mconley

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/43f8f3725d2b