1678159 - Move WritePropertyTime to SpliceableJSONWriter

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Currently the free function WritePropertyTime must be used to write TimeStamps into markers.

This can be easy to miss, and is inconsistent with other data-writing functions, which are all in SpliceableJSONWriter (and base class JSONWriter).

So I think WritePropertyTime should be moved to SpliceableJSONWriter.

Inside StreamJSONMarkerData functions, statements such as:

    mozilla::baseprofiler::WritePropertyTime(aWriter, "prefAccessTime",
                                             aPrefAccessTime);

will become:

    aWriter.TimeProperty("prefAccessTime", aPrefAccessTime);

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1678159 - Move WritePropertyTime to SpliceableJSONWriter::TimeProperty - r?gregtatum

TimeStamps in markers must now be streamed through SpliceableJSONWriter::TimeProperty(name, timestamp).
This is consistent with all other JSON-writing functions being in SpliceableJSONWriter (and base class JSONWriter).

Depends on D97556

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6f9575749d2
Move WritePropertyTime to SpliceableJSONWriter::TimeProperty - r=gregtatum

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d6f9575749d2