1678181 - Output missing marker schema labels (Chart and Table)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1640999 implemented the marker schema.
During that work more labels were introduced in the front-end, I added them as members of MarkerSchema, but I forgot to stream them out to JSON in MarkerSchema::Stream().

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1678181 - Add thorough tests for custom marker definitions - r?gregtatum

This adds tests for custom marker types, exercizing most streaming and schema functions.

Depends on D96971

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1678181 - Output chartLabel and tableLabel in marker schema - r?gregtatum

Depends on D97555

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640999

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Though bug 1640999 landed in 83, MarkerSchema has only just started to be taken into account with bug 1666566.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fac6d5efcd0d
Add thorough tests for custom marker definitions - r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/6ce2cd50b124
Output chartLabel and tableLabel in marker schema - r=gregtatum

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fac6d5efcd0d
https://hg.mozilla.org/mozilla-central/rev/6ce2cd50b124