1679456 - Remove popup opening tokens (replacing them by user activation consumption).

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

These two mechanisms serve basically the same purpose.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1679456 - Use transient user activation for iframe external protocol blocking. r=smaug!,edgar!

I think this allows us to remove TryUsePopupOpeningToken (which is a similar
concept to consuming user activation), and also the ad-hoc <iframe> timing
thing we have from bug 1514547, which should be covered by the user activation
timeout.

Depends on D97640

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1679456 - Disable external-protocol-blocking bypass timer in Nightly. r=smaug!,edgar!

As the use case we know it was needed for should be covered by the previous
patch as well.

This is also process-global, which is a bit odd, given whether a popup-opening
operation succeeds ends up depending on other tabs' activity.

Depends on D98020

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1679456 - Consume user activation on popup opening and remove popup opening tokens. r=smaug!,edgar!

The test tweak is needed because user interaction isn't registered by a
single mouseup, but the test is still valid with that tweak IMO.

Depends on D98021

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32b16732aabc
Use transient user activation for iframe external protocol blocking. r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/8b56e2cc3518
Disable external-protocol-blocking bypass timer in Nightly. r=smaug,edgar

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68af110cd33e
Consume user activation on popup opening and remove popup opening tokens. r=smaug,edgar

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/32b16732aabc
https://hg.mozilla.org/mozilla-central/rev/8b56e2cc3518
https://hg.mozilla.org/mozilla-central/rev/68af110cd33e