1678793 - Firefox branding on New Tab page is too big

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Will]

Attachment: ntp too big.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

I have nothing against the Firefox branding on the New Tab page now, but it's way too big, it actually looks ridiculous and silly. Please consider making it smaller, it's gigantic.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Tom S. (please needinfo tschuster)]

I have a default zoom of 133% and about:newtab now shows a scroll bar. This is not something I ever want.

Comment 3

[John Gruen [:jgruen]]

Hi, just to callout that this pref has been changed so that the logo is not on by default when pocket is enabled in 84. The only time this is not the case is when only search is visible which is no net change from previous

Comment 4

[Pascal Chevrel (relman team) -> :pascalc]

John, could you help relman prioritizing this bug / sending it to the right people maybe? Thanks

Comment 5

[Erica Wright [:ewright]]

Attachment: Bug 1678793 - Resize Firefox logo according to spec.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c162882836a
Resize Firefox logo according to spec. r=prathiksha

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6c162882836a

Comment 8

[Julien Cristau [:jcristau]]

Do we need to do something for 85 here, or can we live with things as-is?

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (86.0a1 Build ID - 20210115035053) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the size of the Firefox logo is 82px.

Comment 10

[Erica Wright [:ewright]]

Comment on attachment 9196450 [details]
Bug 1678793 - Resize Firefox logo according to spec.

Beta/Release Uplift Approval Request

• User impact if declined: We intend to do tests on 85 involving this logo, it would make the test much more accurate if the logo were proprly sized.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS only change
• String changes made/needed: none

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9196450 [details]
Bug 1678793 - Resize Firefox logo according to spec.

approved for 85 rc1

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/cd908cffd02e

Comment 13

[Mathew Hodson]

The regressing bug was uplifted to Firefox 84 so I updated that status.

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (85.0 RC1 Build ID - 20210118153634) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64. Now, I can confirm that the size of the Firefox logo is 82px.