1679927 - Apple VP9 decoder always outputting 8 bits YUV420 images

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

The code always requests kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange [1] format even if the source is 8 bits.

[1] https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/dom/media/platforms/apple/AppleVTDecoder.cpp#616-619

We should add support for 10 bits YUV420 in order to allow for proper display.
With CoreAnimation being used for rendering, we should "just" have to fill the metadata to get HDR rendering going.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1679927 Part 1: Make AppleVTDecoder check color depth and use 10-bit YUV420 when available.

This only stores color bits, not the color depth enum itself.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a43d61af1ff
Part 1: Make AppleVTDecoder check color depth and use 10-bit YUV420 when available. r=media-playback-reviewers,alwu

Comment 3

[Marian-Vasile Laza]

Backed out changeset 2a43d61af1ff (Bug 1679927) for causing build bustages on AppleVTDecoder.cpp.
Backout link
Push with failures
Failure Log

Comment 4

[Brad Werth [:bradwerth]]

Ahh, the kCVPixelFormatType_420YpCbCr10BiPlanarFullRange constant requires macOS SDK 10.13 or greater.

Comment 5

[Brad Werth [:bradwerth]]

Probably easiest to wait for Bug 1696504 to land. The alternative would be to define the necessary constants locally behind an #ifdef which we'd then just have to remove.

Comment 6

[Brad Werth [:bradwerth]]

(In reply to Brad Werth [:bradwerth] from comment #5)

Probably easiest to wait for Bug 1696504 to land. The alternative would be to define the necessary constants locally behind an #ifdef which we'd then just have to remove.

Changing my mind. That Bug could take awhile and there's no need to wait.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a663bfcbe8ac
Part 1: Make AppleVTDecoder check color depth and use 10-bit YUV420 when available. r=media-playback-reviewers,alwu

Comment 8

[Atila Butkovits]

Backed out for causing build bustages on AppleVTDecoder.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4f727ba638a92512508cc3a22f4390c4f901549

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FW3uevWPRMi25a8TNjD6Rg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a663bfcbe8acbdda0b228d6d87b87de46376656a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=363911349&repo=autoland&lineNumber=11303

Comment 9

[Brad Werth [:bradwerth]]

Finally got through the compiler differences between my SDK and the build system SDK, and tested the build remotely. This one should land.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a85ec3cb63f2
Part 1: Make AppleVTDecoder check color depth and use 10-bit YUV420 when available. r=media-playback-reviewers,alwu

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a85ec3cb63f2