1721708 - (hdr-video-macos) Add HDR video playback support on macOS

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

The macOS documentation says that we need to switch to use the AVSampleBufferDisplayLayer in order to have HDR metadata processed, but we’re already planning on doing that for video performance. It’s possible that it also just works as-is, once we tag with the appropriate metadata.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Here's an example video with HDR that makes it really obvious when it's being used: https://www.youtube.com/watch?v=3q3RFE-9CFw

Comment 2

[kkim]

Description:
Please provide an explanation of the feature or change. Include a description of the user scenario in which it would be used and how the user would complete the task(s). macOS users with HDR-capable displays will be able to view HDR encoded videos with full colors. It will already be switched to on without any action needed from the user.

Screenshots and visual UI specs are welcome, but please include sufficient accompanying explanation so that blind members of the accessibility team are able to understand the feature/change. N/A - this is a visual feature.

How do we test this?
If there is an implementation to test, please provide instructions for testing it; e.g. setting preferences, other preparation, how to trigger the UI, etc.
The feature should already be set to on in Nightly -- no prefs needed.

The primary before-and-after we're showing in our spec is sourced from a Bugzilla-hosted webm test video file https://bug1495025.bmoattachments.org/attachment.cgi?id=9012925. It actually looks better than that on a Mac HDR-capable screen because there is even more color definition.

Please refer to our QA feature documentation (https://docs.google.com/document/d/1mB5rCp_NbgnBX-Ymo7-9Q46AXKFTKGGDijSblRqeBfk/edit#) for more information.

For additional testing, our media team has assembled a library of HDR video files for testing here: https://drive.google.com/drive/folders/1dSPUmJ_Y99-VL6TxfndPbISyUfRJ3SAY.
In order to view them properly, you have to download the files locally and play them. If you attempt to play them through Google Drive, they are processed through the Video Player for Google Drive, which transcodes the videos down to standard dynamic range.

When will this ship?
Tracking bug/issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1721708
Design documents (e.g. Product Requirements Document, UI spec): https://docs.google.com/document/d/1qi0vMsf1LcSgZGukVmpsjRf7PCU-yFuvzTQav--H0wA/edit#bookmark=id.lr8e474g53gj (write-up includes library of video files we can test)
Engineering lead: Brad Werth
Product manager: Karen Kim

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:
Color contrast

Describe any areas of concern to which you want the accessibility team to give special attention:
We want to make sure this won't be extremely bothersome to any of our macOS users who have sensitivity to brightness/color due to the switch to HDR video.