1680611 - Mark nsFocusManager methods as MOZ_CAN_RUN_SCRIPT if necessary

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Because it can fire a synchronous focus event.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

I hit this bug.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 1: Mark all `nsFocusManager` methods whose names explain that they may dispatch events as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 2: Mark `nsFocusManager::SetFocusedWindowWithCallerType` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147060

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 3: Mark `nsFocusManager::WindowLowered()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147061

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 4: Mark `nsFocusManager::WindowHidden()` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147062

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 5: Get rid of `nsFocusManager::FocusPlugin()` because of unused r=smaug!

Depends on D147063

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 6: Mark `nsFocusManager::MoveCaretToFocus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147064

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 7: Mark `nsFocusManager::BlurImpl()` and `nsFocusManager::BlurFromOtherProcess()` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147065

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 8: Mark `nsFocusManager::Blur` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147066

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 9: Mark `nsFocusManager::Focus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147067

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 10: Mark `nsFocusManager::Flush*()` and their callers in `nsFocusManager` r=smaug!

Depends on D147068

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 11: Mark `nsFocusManager::NotifyOfReFocus()` as `MOZ_CAN_RUN_SCRIPT` r=smaug!

Depends on D147071

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1680611 - part 10-2: Make `nsFocusManager::GetNextTabbableContentInAncestorScopes` stop taking pointer to an `nsCOMPtr` r=smaug!

Instead, returning things with a tiny struct is clearer what are the result and
maybe modified in the caller side.

Depends on D147069

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6875ec5cd247
part 1: Mark all `nsFocusManager` methods whose names explain that they may dispatch events as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/1842c19f2ccd
part 2: Mark `nsFocusManager::SetFocusedWindowWithCallerType` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug,media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/5768dbdd45ab
part 3: Mark `nsFocusManager::WindowLowered()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/02e53ff426c9
part 4: Mark `nsFocusManager::WindowHidden()` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/7cfd4c5adbc7
part 5: Get rid of `nsFocusManager::FocusPlugin()` because of unused r=smaug
https://hg.mozilla.org/integration/autoland/rev/50c993d5c294
part 6: Mark `nsFocusManager::MoveCaretToFocus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/45bccd2ca9dd
part 7: Mark `nsFocusManager::BlurImpl()` and `nsFocusManager::BlurFromOtherProcess()` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/58f913928b11
part 8: Mark `nsFocusManager::Blur` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/ce978103b160
part 9: Mark `nsFocusManager::Focus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug
https://hg.mozilla.org/integration/autoland/rev/781146dd61d8
part 10: Mark `nsFocusManager::Flush*()` and their callers in `nsFocusManager` r=smaug
https://hg.mozilla.org/integration/autoland/rev/0ab9981db037
part 11: Mark `nsFocusManager::NotifyOfReFocus()` as `MOZ_CAN_RUN_SCRIPT` r=smaug

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6875ec5cd247
https://hg.mozilla.org/mozilla-central/rev/1842c19f2ccd
https://hg.mozilla.org/mozilla-central/rev/5768dbdd45ab
https://hg.mozilla.org/mozilla-central/rev/02e53ff426c9
https://hg.mozilla.org/mozilla-central/rev/7cfd4c5adbc7
https://hg.mozilla.org/mozilla-central/rev/50c993d5c294
https://hg.mozilla.org/mozilla-central/rev/45bccd2ca9dd
https://hg.mozilla.org/mozilla-central/rev/58f913928b11
https://hg.mozilla.org/mozilla-central/rev/ce978103b160
https://hg.mozilla.org/mozilla-central/rev/781146dd61d8
https://hg.mozilla.org/mozilla-central/rev/0ab9981db037