Mark nsFocusManager methods as MOZ_CAN_RUN_SCRIPT if necessary
Categories
(Core :: DOM: UI Events & Focus Handling, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: saschanaz, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(11 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Because it can fire a synchronous focus event.
Assignee | ||
Comment 1•2 years ago
|
||
I hit this bug.
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D147060
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D147061
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D147062
Assignee | ||
Comment 6•2 years ago
|
||
Depends on D147063
Assignee | ||
Comment 7•2 years ago
|
||
Depends on D147064
Assignee | ||
Comment 8•2 years ago
|
||
Depends on D147065
Assignee | ||
Comment 9•2 years ago
|
||
Depends on D147066
Assignee | ||
Comment 10•2 years ago
|
||
Depends on D147067
Assignee | ||
Comment 11•2 years ago
|
||
Depends on D147068
Assignee | ||
Comment 12•2 years ago
|
||
Depends on D147071
Assignee | ||
Comment 13•2 years ago
|
||
Instead, returning things with a tiny struct is clearer what are the result and
maybe modified in the caller side.
Depends on D147069
Updated•2 years ago
|
Comment 14•2 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/6875ec5cd247 part 1: Mark all `nsFocusManager` methods whose names explain that they may dispatch events as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/1842c19f2ccd part 2: Mark `nsFocusManager::SetFocusedWindowWithCallerType` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug,media-playback-reviewers,chunmin https://hg.mozilla.org/integration/autoland/rev/5768dbdd45ab part 3: Mark `nsFocusManager::WindowLowered()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/02e53ff426c9 part 4: Mark `nsFocusManager::WindowHidden()` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/7cfd4c5adbc7 part 5: Get rid of `nsFocusManager::FocusPlugin()` because of unused r=smaug https://hg.mozilla.org/integration/autoland/rev/50c993d5c294 part 6: Mark `nsFocusManager::MoveCaretToFocus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/45bccd2ca9dd part 7: Mark `nsFocusManager::BlurImpl()` and `nsFocusManager::BlurFromOtherProcess()` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/58f913928b11 part 8: Mark `nsFocusManager::Blur` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/ce978103b160 part 9: Mark `nsFocusManager::Focus()` and its callers in `nsFocusManager` as `MOZ_CAN_RUN_SCRIPT` r=smaug https://hg.mozilla.org/integration/autoland/rev/781146dd61d8 part 10: Mark `nsFocusManager::Flush*()` and their callers in `nsFocusManager` r=smaug https://hg.mozilla.org/integration/autoland/rev/0ab9981db037 part 11: Mark `nsFocusManager::NotifyOfReFocus()` as `MOZ_CAN_RUN_SCRIPT` r=smaug
Comment 15•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6875ec5cd247
https://hg.mozilla.org/mozilla-central/rev/1842c19f2ccd
https://hg.mozilla.org/mozilla-central/rev/5768dbdd45ab
https://hg.mozilla.org/mozilla-central/rev/02e53ff426c9
https://hg.mozilla.org/mozilla-central/rev/7cfd4c5adbc7
https://hg.mozilla.org/mozilla-central/rev/50c993d5c294
https://hg.mozilla.org/mozilla-central/rev/45bccd2ca9dd
https://hg.mozilla.org/mozilla-central/rev/58f913928b11
https://hg.mozilla.org/mozilla-central/rev/ce978103b160
https://hg.mozilla.org/mozilla-central/rev/781146dd61d8
https://hg.mozilla.org/mozilla-central/rev/0ab9981db037
Assignee | ||
Updated•2 years ago
|
Description
•