Closed Bug 16810 Opened 25 years ago Closed 25 years ago

[dogfood]<label> is broken for radio buttons/checkboxes

Categories

(Core :: Layout: Form Controls, defect, P3)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Brade, Assigned: rods)

References

Details

(Whiteboard: [PDT-])

Attachments

(1 file)

simple test case
247 bytes, text/html
Details 
Clicking on the labels for radio buttons doesn't toggle the radio button.

The strings should be in <label> tags so that the behavior can be more like in
4.x with native widgets.

I consider this dogfood since it can be really hard to click on just the radio
button when I'm used to clicking on the strings.
Is this related to bug 5393?
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
*** This bug has been marked as a duplicate of 5393 ***
Status: RESOLVED → VERIFIED
Status: VERIFIED → REOPENED
Summary: [4.xP][dogfood]click on strings for radio btns doesn't toggle radio btn → [4.xP][dogfood]<label> is broken
Resolution: DUPLICATE → ---
Summary: [4.xP][dogfood]<label> is broken → [dogfood]<label> is broken
Assignee: shuang → rickg
Status: REOPENED → NEW
This looks like <label> is broken.
The stings have the lable tag but is does not work.
Assignee: rickg → karnaze
Component: Pref UI → HTML Form Controls
Summary: [dogfood]<label> is broken → [dogfood]<label> is broken for radio buttons/checkboxes
Looking in some of the editor dialogs, I see that the label does appropriately
work with an editfield (input) but it doesn't seem to work with radio buttons or
check boxes.

change component to HTML Form Controls and reassign
Assignee: karnaze → kmcclusk
Reassigning to Kevin.
This bug is a regression in 5.0 and is needed to have a smooth UI in places like
editor dialogs and preferences.
Hm, I'd swear labels worked for radio buttons not too long ago...
Whiteboard: [PDT-]
removing [PDT-] from status whiteboard.  I don't see any rationale for it not to
be PDT+.

I would argue that it should be fixed soon since it is a regression and because
the UI for our app will need to function consistently with other apps.  Our UI
relies on this working.
Whiteboard: [PDT-]
For dogfood use... hit the button.... This was a "feature" in some older 4.x
versions on various HTML forms.... it can be worked around for dogfood.
Whiteboard: [PDT-]
*** Bug 14822 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Target Milestone: M12
OS: Mac System 8.5 → All
Hardware: Macintosh → All
Figured this one out for checkboxes at least.

nsLabelFrame::HandleEvent calls mControlFrame->MouseClicked when the mouse
button is released.  The MouseClicked method was removed from checkbox frames on
11-Aug-99 during a general cleanup.

We could get the click event to the radio and checkbox frames by updating the
content as needed.  ???
*** Bug 18964 has been marked as a duplicate of this bug. ***
Target Milestone: M12 → M13
QA Contact update.
See also bug 6747
Target Milestone: M13 → M14
Moving to M14.
Blocks: 6747
Assignee: kmcclusk → rods
Status: ASSIGNED → NEW
Reassigning to Rod.
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Attached file simple test case — 

    
    

    
  
fixed

    
    

    
  
Marking VERIFIED FIXED on:
 - Linux6 2000-01-24-01 M13 Commercial build
 - Win98 2000-01-24-01 M13 Commercial build
 - MacOS86 2000-01-24-01 M13 Commercial build
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: