1681023 - setComposeDetails and begin* functions of compose API should use body and plainTextBody as compose mode selectors

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

The default compose mode should not have an effect on the compose type of the begin* functions of the compose API. The outcome of

beginNew(
  messagId,
  {
   body:"Something"
  }
);

should always create an HTML email.

Comment 1

[John Bieling (:TbSync)]

Attachment: bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors.patch

Comment 2

[John Bieling (:TbSync)]

Attachment: bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors.patch

Fixed spelling error in error msg.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9191633 [details] [diff] [review]
bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors.patch

Review of attachment 9191633 [details] [diff] [review]:
-----------------------------------------------------------------

We should document that overriding the user's format preferences is a really good way to annoy users.

Comment 4

[John Bieling (:TbSync)]

try on c-c:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=399b02ca84acbc38490a750ee11b78528df9f19c

Comment 5

[John Bieling (:TbSync)]

Attachment: bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors_v2.patch

Added description to schema to document behavior.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1ba1e7f0485
use body and plainTextBody in setComposeDetails and begin* functions of compose API as compose mode selectors. r=darktrojan

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9191848 [details] [diff] [review]
bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors_v2.patch

[Approval Request Comment]
User impact if declined:
Add-on developers can not use the latest fixes and improvements of our WebExtension API.

Testing completed (on c-c, etc.):
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=3cdff293d5d1bd77777f5da371caaa02c4b05de3

Risk to taking this patch (and alternatives if risky):
I hope none

Remark:
The provided try run includes all bugs I want to uplift for TB 78.7 and shows a working patch order.
The first one, which does not have a bug number in the commit messages is Bug 1680653.
This bug is the 8th one.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9191848 [details] [diff] [review]
bug1681023_use_body_and_plainTextBody_as_compose_mode_selectors_v2.patch

[Triage Comment]
Approved for esr78

Comment 9

[Dave Miller [:justdave]]

Thunderbird 78.7.0:
https://hg.mozilla.org/releases/comm-esr78/rev/78bcb38dcef2