Back out highlights and logo changes on newtab page
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
People
(Reporter: ewright, Assigned: ewright)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
We will soon know if we need to back out these three bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1677852
https://bugzilla.mozilla.org/show_bug.cgi?id=1678740
https://bugzilla.mozilla.org/show_bug.cgi?id=1677836
This bug is in preparation for that.
Assignee | ||
Comment 1•4 years ago
|
||
[Tracking Requested - why for this release]: Patches were landed in 84, which may need to be backed out before moving to release.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Comment on attachment 9192096 [details]
Bug 1681428 - back out highlights and logo changes
Beta/Release Uplift Approval Request
- User impact if declined: If declined, this patch will disable the Highlights feature
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Enable the Highlights section in your browser. After this patch is applied the Highlights section should remain enabled.
Additionally the Firefox logo should only be enabled on New Tab when only the search field is visible
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky. This is a revision of three small pref-flipping patches.
- String changes made/needed: None
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 6•4 years ago
|
||
Comment on attachment 9192096 [details]
Bug 1681428 - back out highlights and logo changes
Approved for 84.0rc2.
Comment 7•4 years ago
|
||
I have verified this enhancement and I can confirm the following:
- the "Highlights" section is displayed by default on the "New Tab" page.
- The "Firefox" logo is visible on the "New Tab" page when only the in-content "Search" bar is displayed.
Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201210092800) installed on Windows 10 x64, Mac 10.15, and Linux Mint 20 x64.
Comment 8•4 years ago
|
||
bugherder uplift |
Comment 9•4 years ago
|
||
I have verified this enhancement and I can confirm the following:
- the "Highlights" section is displayed by default on the "New Tab" page.
- the "Firefox" logo is visible on the "New Tab" page when only the in-content "Search" bar is displayed.
Verified using the latest Firefox 84.0 RC2 Build ID - 20201210144358 installed on Windows 10 x64, Mac 10.15, and Linux Mint 20 x64.
Description
•