Closed Bug 1681428 Opened 4 years ago Closed 4 years ago

Back out highlights and logo changes on newtab page

Categories

(Firefox :: New Tab Page, enhancement, P1)

Firefox 84
enhancement

Tracking

()

VERIFIED FIXED
85 Branch
Tracking Status
firefox84 + verified
firefox85 + verified

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Patches were landed in 84, which may need to be backed out before moving to release.

Assignee: nobody → ewright
Status: NEW → ASSIGNED
Pushed by ewright@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63bc7c15c53d back out highlights and logo changes r=thecount

Comment on attachment 9192096 [details]
Bug 1681428 - back out highlights and logo changes

Beta/Release Uplift Approval Request

  • User impact if declined: If declined, this patch will disable the Highlights feature
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Enable the Highlights section in your browser. After this patch is applied the Highlights section should remain enabled.

Additionally the Firefox logo should only be enabled on New Tab when only the search field is visible

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky. This is a revision of three small pref-flipping patches.
  • String changes made/needed: None
Attachment #9192096 - Flags: approval-mozilla-release?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
QA Whiteboard: [qa-triaged]

Comment on attachment 9192096 [details]
Bug 1681428 - back out highlights and logo changes

Approved for 84.0rc2.

Attachment #9192096 - Flags: approval-mozilla-release? → approval-mozilla-release+

I have verified this enhancement and I can confirm the following:

  • the "Highlights" section is displayed by default on the "New Tab" page.
  • The "Firefox" logo is visible on the "New Tab" page when only the in-content "Search" bar is displayed.

Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201210092800) installed on Windows 10 x64, Mac 10.15, and Linux Mint 20 x64.

I have verified this enhancement and I can confirm the following:

  • the "Highlights" section is displayed by default on the "New Tab" page.
  • the "Firefox" logo is visible on the "New Tab" page when only the in-content "Search" bar is displayed.

Verified using the latest Firefox 84.0 RC2 Build ID - 20201210144358 installed on Windows 10 x64, Mac 10.15, and Linux Mint 20 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1682312
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: