1681539 - Localize profiler presets

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Greg Tatum [:gregtatum]]

Attachment: image.png

I ran into a few issues localizing the presets, and didn't take them on in the initial bit of work to localize the profiler recording UI. The presets strings need to be shared between the Firefox main UI, and the devtools/client/performance-new infrastructure. This means probably putting them in the appmenu.ftl file. I had trouble with the menuitem rendering correctly, and with the descriptionHeightWorkaround being the wrong size when I initially tried this localization.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Localize all presets r=jdescottes!

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

The patch is nearly ready -- except I see some of the problems Greg saw. I don't see issues with the menu item rendering (I think) but the height workaround does have issue.

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - Add a profiler marker for descriptionHeightWorkaround r=mconley

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Use a shortcut when using createElement r=jdescottes!

Depends on D126203

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Move all of the popup initialization to one function in popup.jsm.js r=jdescottes!

Depends on D126204

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Use a shared FTL file between all profiler user interfaces r=jdescottes!

This also uses the translation for the Custom preset in these user
interfaces.

Depends on D126205

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Wait until the extra FTL file is loaded before opening the popup r=jdescottes!

This uses a sentinel element as well as a MutationObserver to detect
when the extra FTL file is loaded.

Depends on D126206

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: Bug 1681539 - [devtools performance] Move the translation for the Custom preset to the new shared file, and use it in all panels r=jdescottes!

Depends on D126207

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

latest try (auto) is https://treeherder.mozilla.org/jobs?repo=try&revision=6654a401ff502e0835808a7dd90987c28c346353
It looks green enough!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/556b5fffc96d
Add a profiler marker for descriptionHeightWorkaround r=mconley
https://hg.mozilla.org/integration/autoland/rev/4c640c8a94a6
[devtools performance] Move all of the popup initialization to one function in popup.jsm.js r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5f8305eba055
[devtools performance] Localize all presets r=jdescottes,fluent-reviewers,flod

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/556b5fffc96d
https://hg.mozilla.org/mozilla-central/rev/4c640c8a94a6
https://hg.mozilla.org/mozilla-central/rev/5f8305eba055