Closed Bug 1599774 Opened 3 years ago Closed 2 years ago

Localize about:profiling

Categories

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

task

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

We should localize about:profiling after the interface stabilizes a bit, that way we don't have to worry about changing localization strings until we are ready.

Attached file Bug 1599774 - Localize about:profiling (obsolete) —
Assignee: nobody → gtatum
Status: NEW → ASSIGNED

I have patches for this which I've attached, but need to spend more time on it before it's ready for review. It's also not handling the CustomizableUI side of it yet.

Note for the future on implementing localization for the popup

Add popup strings here: https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/appmenu.ftl
Search for data-l10n-id for examples of usage.

Attachment #9141402 - Attachment is obsolete: true
Blocks: 1681539

This was based off of the differential revision:
https://phabricator.services.mozilla.com/D71403

I started a new revision as the old one had bitrotted quite a bit. I
handled flod's review feedback from the previous review.

This patch will require a follow-up with handling the profiler presets.
See Bug 1681539.

This handles most of the localization, but will require a few follow-ups.

First off is Bug 1681539, which is for localizing profiler presets. There
isn't anything too weird about this for the DevTools and about:profilling
context, but requires a solution for the popup. The appmenu.ftl bundle
might need to be included.

I did not localize profiler feature list, nor the byte size computation.

Depends on D99274

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c84e2486b321
Localize the profiler popup; r=julienw,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/589ce4061beb
Localize about:profiling and DevTools perf panel; r=julienw,flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Depends on: 1688400
No longer blocks: 1681539
Depends on: 1681539
Blocks: 1682333
No longer depends on: 1682333
Blocks: 1418056
See Also: 1418056
You need to log in before you can comment on or make changes to this bug.