1599774 - Localize about:profiling

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

We should localize about:profiling after the interface stabilizes a bit, that way we don't have to worry about changing localization strings until we are ready.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1599774 - Localize about:profiling

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

I have patches for this which I've attached, but need to spend more time on it before it's ready for review. It's also not handling the CustomizableUI side of it yet.

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

Note for the future on implementing localization for the popup

Add popup strings here: https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/appmenu.ftl
Search for data-l10n-id for examples of usage.

Comment 4

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1599774 - Localize the profiler popup; r?julienw

This was based off of the differential revision:
https://phabricator.services.mozilla.com/D71403

I started a new revision as the old one had bitrotted quite a bit. I
handled flod's review feedback from the previous review.

This patch will require a follow-up with handling the profiler presets.
See Bug 1681539.

Comment 5

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1599774 - Localize about:profiling and DevTools perf panel; r?julienw

This handles most of the localization, but will require a few follow-ups.

First off is Bug 1681539, which is for localizing profiler presets. There
isn't anything too weird about this for the DevTools and about:profilling
context, but requires a solution for the popup. The appmenu.ftl bundle
might need to be included.

I did not localize profiler feature list, nor the byte size computation.

Depends on D99274

Comment 6

[Greg Tatum [:gregtatum] (REO Fx132)]

https://treeherder.mozilla.org/jobs?repo=try&revision=0633a6a50cec44f8ad5975915b4bc865b38c6a6e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c84e2486b321
Localize the profiler popup; r=julienw,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/589ce4061beb
Localize about:profiling and DevTools perf panel; r=julienw,flod

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c84e2486b321
https://hg.mozilla.org/mozilla-central/rev/589ce4061beb