1683131 - Have telemetry probes to measure how much cost would it take to sniff a no-cors and cross-origin response

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Tom Tung [:tt, :ttung]]

• Would be good to know the number of response that has a mismatched MIME type results with its sniffed results.
• Would be good to know how much time would it take for sniffing for responses that weren't needed to be sniffed. (Also check the worst cases time)

Comment 1

[Anne (:annevk)]

I think for useful results here we should implement https://github.com/annevk/orb except for step 14 (parsing JSON/JavaScript) and then add telemetry for step 14 in particular. Perhaps it's useful to compare how often we invoke the algorithm versus how often we hit that step? And when we hit that step we might want to report how big responses are to get an idea about performance impact? (The cost of sniffing for media should be marginal as it's only a couple bytes, I don't think we need to measure that.)

Comment 2

[Tom Tung [:tt, :ttung]]

Had a meeting with Anne and we think that, in this bug, we actually want to know:

• How much percentage of requests is blocked, is allowed, or needs to be parsed per source (e.g. media, video, ..etc)?
• How much time does it take? (performance)

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1683131 - Add telemetry probes to record time and result for checking a opaque response is allowed or not;

Depends on D102449

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1683131 - Add a test for telemetry

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: request-bug1683131.md

Comment 6

[Chris H-C :chutten]

Comment on attachment 9204850 [details]
request-bug1683131.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 93.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels. (The request says nightly-only, which may be true for the feature, but OPAQUE_RESPONSE_BLOCKING is configured to be collectable in all channels)

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :tt is responsible for renewing or removing the collection before it expires in Firefox 93.

---

Result: datareview+

Comment 7

[Tom Tung [:tt, :ttung]]

Handover this to Eden.

Comment 8

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1683131 - Fix namespace ambiguity issue on ipc::Endpoint after including nsHttpChannel in imgLoader;

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c7a45e20b50
Add telemetry probes to record time and result for checking a opaque response is allowed or not; r=necko-reviewers,annevk,dragana
https://hg.mozilla.org/integration/autoland/rev/276f016ddc67
Add a test for telemetry r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8ffef57e27d2
Fix namespace ambiguity issue on ipc::Endpoint after including nsHttpChannel in imgLoader; r=necko-reviewers,kershaw

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2c7a45e20b50
https://hg.mozilla.org/mozilla-central/rev/276f016ddc67
https://hg.mozilla.org/mozilla-central/rev/8ffef57e27d2

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/eb3c49d8feaf
Backed out 12 changesets (bug 1683131, bug 1696111, bug 1695987) for causing crashes(Bug 1701151). a=backout

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b84c1b571ad
Add telemetry probes to record time and result for checking a opaque response is allowed or not; r=necko-reviewers,annevk,dragana
https://hg.mozilla.org/integration/autoland/rev/a10781b36673
Add a test for telemetry r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/84a8d70fe0be
Fix namespace ambiguity issue on ipc::Endpoint after including nsHttpChannel in imgLoader; r=necko-reviewers,kershaw

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1b84c1b571ad
https://hg.mozilla.org/mozilla-central/rev/a10781b36673
https://hg.mozilla.org/mozilla-central/rev/84a8d70fe0be