1696111 - Opaque Response Blocking v0

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Tom Tung [:tt, :ttung]]

Scope of v0:

• Implement https://github.com/annevk/orb except for Javascript/JSON parsing without actually blocking.
• Apply changes in https://github.com/annevk/orb/pull/16/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
• Collect telemetry probes to measure impacts.

We have already had patches, but I am going to move them here so that it's easier to track progress.

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Add a pref for ORB and disable it by default;

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Add functions to determine opaque-safelisted MIME type, opaque-blocklisted MIME type and opaque-blocklisted-never-sniffed MIME type;

These functions are defined at https://github.com/annevk/orb.

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - ORB core Implementation;

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Extract the code for parsing range header string out and use it later;

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Make LoadInfo know if the request is triggered from a media element and if it's an initial request.

Comment 6

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Sniff and check the initial media request and allow its subsequent requests;

This implements the changes in https://github.com/annevk/orb/pull/16/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Comment 7

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Enable the pref for ORB on Nightly;

Depends on D106891

Comment 8

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2365d0cdd2264a8744a58d2f125c08e58ff4d50
try without enabling the pref on Nightly (to simulate Beta and Release): https://treeherder.mozilla.org/#/jobs?repo=try&revision=3646db16b523e88b9939e410478a9e857079a752

Comment 9

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #8)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2365d0cdd2264a8744a58d2f125c08e58ff4d50
try without enabling the pref on Nightly (to simulate Beta and Release): https://treeherder.mozilla.org/#/jobs?repo=try&revision=3646db16b523e88b9939e410478a9e857079a752

Some tests failed because the boolean pref was accessed on the background thread.
Update patches to make it atomic boolean.

try: https://treeherder.mozilla.org/jobs?repo=try&revision=a001bc892322dff5f737166ed306478983ef9a48
try w/o: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d820ba43c8262b573c2f562247c5f3ff49ac889

Comment 10

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1696111 - Use sniffers in the requested category;

After applying D102448,
uriloader/exthandler/tests/mochitest/test_nullCharFile.xhtml starts to fail.
The reason is that it adds image sniffer into net-content-sniffers which is not
expected.

Such that, this patch

• adds two other sniffers category:
  • orb-content-sniffers
    • The sniffers that are needed in ORB.
  • net-and-orb-content-sniffers
    • The sniffers that are in either orb-content-sniffers or net-content-sniffers.
• changes the way to ensure we only use the sniffers in the
  requested category.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/642bdd52fd57
Add a pref for ORB and disable it by default; r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/51a16dfabc98
Add functions to determine opaque-safelisted MIME type, opaque-blocklisted MIME type and opaque-blocklisted-never-sniffed MIME type; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3fdc8089a46f
ORB core Implementation; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/d60c38f8939a
Extract the code for parsing range header string out and use it later; r=alwu,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/fab7f4cd445d
Make LoadInfo know if the request is triggered from a media element and if it's an initial request. r=necko-reviewers,alwu,dragana
https://hg.mozilla.org/integration/autoland/rev/e4d01b88e517
Sniff and check the initial media request and allow its subsequent requests; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/2946eff1e9c8
Enable the pref for ORB on Nightly; r=valentin
https://hg.mozilla.org/integration/autoland/rev/11fdb503d537
Use sniffers in the requested category; r=necko-reviewers,valentin

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/642bdd52fd57
https://hg.mozilla.org/mozilla-central/rev/51a16dfabc98
https://hg.mozilla.org/mozilla-central/rev/3fdc8089a46f
https://hg.mozilla.org/mozilla-central/rev/d60c38f8939a
https://hg.mozilla.org/mozilla-central/rev/fab7f4cd445d
https://hg.mozilla.org/mozilla-central/rev/e4d01b88e517
https://hg.mozilla.org/mozilla-central/rev/2946eff1e9c8
https://hg.mozilla.org/mozilla-central/rev/11fdb503d537

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f61d79772d0
Add a pref for ORB and disable it by default; r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/fa0aa347f7fd
Add functions to determine opaque-safelisted MIME type, opaque-blocklisted MIME type and opaque-blocklisted-never-sniffed MIME type; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/f6ff0fe4970c
ORB core Implementation; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c117ba41ccb1
Extract the code for parsing range header string out and use it later; r=alwu,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/b4fe94d08876
Make LoadInfo know if the request is triggered from a media element and if it's an initial request. r=necko-reviewers,alwu,dragana
https://hg.mozilla.org/integration/autoland/rev/9e001023eda0
Sniff and check the initial media request and allow its subsequent requests; r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/e886ab54b5f1
Enable the pref for ORB on Nightly; r=valentin
https://hg.mozilla.org/integration/autoland/rev/cbbcad052794
Use sniffers in the requested category; r=necko-reviewers,valentin

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7f61d79772d0
https://hg.mozilla.org/mozilla-central/rev/fa0aa347f7fd
https://hg.mozilla.org/mozilla-central/rev/f6ff0fe4970c
https://hg.mozilla.org/mozilla-central/rev/c117ba41ccb1
https://hg.mozilla.org/mozilla-central/rev/b4fe94d08876
https://hg.mozilla.org/mozilla-central/rev/9e001023eda0
https://hg.mozilla.org/mozilla-central/rev/e886ab54b5f1
https://hg.mozilla.org/mozilla-central/rev/cbbcad052794