1677300 - Frequent browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | [JavaScript Error: "uncaught exception: Object"] -

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=321785369&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Gq5fzGv_RqS3T8XPnHnkpw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - TEST-PASS | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | Menu item was removed from the popup. - 
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Closing menu popup.
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Leaving test bound testDeletingMenuItems
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Entering test bound no_errors_when_bookmarks_placed_in_palette
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Buffered messages finished
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | [JavaScript Error: "uncaught exception: Object"] - 
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Stack trace:
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js:observe:229
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | There should be no console errors - Got 1, expected +0
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - Stack trace:
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-11-14T11:32:23.000Z] 11:32:22     INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js:no_errors_when_bookmarks_placed_in_palette:239
[task 2020-11-14T11:32:23.000Z] 11:32:23     INFO - GECKO(2060) | [Parent 2060, Main Thread] WARNING: 'NS_FAILED(aRv)', file /builds/worker/checkouts/gecko/netwerk/ipc/NeckoParent.cpp:914
[task 2020-11-14T11:32:23.000Z] 11:32:23     INFO - GECKO(2060) | [Child 2063, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsBaseChannel.cpp:928
[task 2020-11-14T11:32:23.000Z] 11:32:23     INFO - GECKO(2060) | JavaScript error: , line 0: uncaught exception: Object
[task 2020-11-14T11:32:23.000Z] 11:32:23     INFO - Console message: [JavaScript Error: "uncaught exception: Object"]
[task 2020-11-14T11:32:23.000Z] 11:32:23     INFO - Leaving test bound no_errors_when_bookmarks_placed_in_palette```

Comment 1

[Natalia Csoregi [:nataliaCs]]

Jared, can you take a look?
Thank you.

Comment 2

[Intermittent Failures Robot]

3 failures in 4040 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform breakdown:

• macosx1014-64-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2020-11-09&endday=2020-11-15&tree=all

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1674091

Comment 4

[Intermittent Failures Robot]

28 failures in 4810 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 26
• try: 1

Platform breakdown:

• linux1804-64: 4
• macosx1014-64-qr: 22
• windows10-64: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2020-11-16&endday=2020-11-22&tree=all

Comment 5

[:Gijs (he/him)]

I think this might be fixed?

Comment 6

[(PTO June 19-July 7) Ryan VanderMeulen]

No instances since November 20. Good enough for me.

Comment 7

[Alexandru Michis [:malexandru]]

Ryan, this looks to have appeared again, should we reopen this bug?
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=1359af4d35d17f5db3e8e35e34e2f86d2a5b4ea2&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc3&tochange=be05e6b10ddfb4f6aa5fd10d69c3e3641bce3c69&selectedTaskRun=KiwkCRYVQY2qSf0hgmb36w.0

Comment 8

[(PTO June 19-July 7) Ryan VanderMeulen]

Sure.

Comment 9

[Andreea Pavel [:apavel]]

filter by test path https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&test_paths=browser%2Fcomponents%2Fplaces%2Ftests%2Fbrowser&tochange=f01f746874d4b81eb44ec92a588edfb72b7329a8&fromchange=ea5674f9a511fda3697a159e2be34fad0623dda3&selectedTaskRun=HRZz_BKfTiaVoL2_J0Sf8Q.0
Treeherder

and the backfill https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&tochange=f01f746874d4b81eb44ec92a588edfb72b7329a8&fromchange=ea5674f9a511fda3697a159e2be34fad0623dda3&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc1&selectedTaskRun=HRZz_BKfTiaVoL2_J0Sf8Q.0

Comment 10

[:Gijs (he/him)]

Jared, can you remind me why we're checking for errors in this test in this way? I suspect this uncaught exception is coming from somewhere else, but it's not clear where from, so it'll be a bit of a nightmare to debug...

Comment 11

[Itiel]

Judging by the error description alone, it seems awfully similar to bug 1586741...

Comment 12

[Intermittent Failures Robot]

27 failures in 4060 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #46 most frequent failure this week.

Repository breakdown:

• autoland: 17
• mozilla-central: 6
• try: 4

Platform breakdown:

• macosx1014-64-qr: 22
• linux1804-64-tsan: 3
• macosx1014-64-shippable-qr: 1
• macosx1014-64-devedition-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2020-12-07&endday=2020-12-13&tree=all

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

I added the test that looks for any exceptions because an exception was getting thrown when trying to update the Other Bookmarks folder visibility if the toolbar was in the palette. There's a couple things we can do here:

1. Check for specific exception messages and ignore the rest.
2. To help with debugging, change ok(false, error.message); to

ok(false, `${error.message}, ${error.stack}, ${JSON.stringify(error)}`);

Comment 14

[:Gijs (he/him)]

Attachment: Bug 1677300 - improve logging during browser_toolbar_other_bookmarks.js

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5b44b8b0de4
improve logging during browser_toolbar_other_bookmarks.js DONTBUILD

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a5b44b8b0de4

Comment 17

[:Gijs (he/him)]

That didn't help. :-(

[task 2020-12-16T11:38:35.948Z] 11:38:35 INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_toolbar_other_bookmarks.js | [JavaScript Error: "uncaught exception: Object"], undefined, {"message":"[JavaScript Error: "uncaught exception: Object"]","logLevel":3,"timeStamp":1608118715705,"debug":0,"info":1,"warn":2,"error":3} -

Comment 18

[:Gijs (he/him)]

These types of errors are the bane of our existence - they're really hard to track down and often not directly related to what's happening in a given test.

Kris, how hard would it be to assert in debug builds if system-privileged code throws exceptions or rejects promises in a way that produces these useless messages?

Comment 19

[:Gijs (he/him)]

This particular intermittent isn't happening on release branch, and didn't happen on beta when 84 was on beta, so we shouldn't mark 84 as affected (and anyway we probably wouldn't uplift further changes there if they were automation/debug-specific).

Comment 20

[Intermittent Failures Robot]

26 failures in 3421 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• autoland: 14
• mozilla-central: 7
• mozilla-beta: 2
• try: 3

Platform breakdown:

• macosx1014-64-qr: 18
• linux1804-64-tsan: 5
• macosx1014-64-devedition-qr: 1
• linux1804-64: 1
• macosx1014-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2020-12-14&endday=2020-12-20&tree=all

Comment 21

[:Gijs (he/him)]

Looks like this went away with bug 1674840 and the fix for bug 1683206. I don't understand why, but there's probably not much point keeping this open. I filed bug 1684043 to make changes to the JS engine to avoid this class of problems being so hard to diagnose/fix.

Comment 22

[Intermittent Failures Robot]

1 failures in 525 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2020-12-28&endday=2021-01-03&tree=all

Comment 23

[Intermittent Failures Robot]

1 failures in 2956 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-devedition-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677300&startday=2021-01-04&endday=2021-01-10&tree=all